Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix management footer logo spacing bug #30654

Merged
merged 7 commits into from
Feb 14, 2019
Merged

Fix management footer logo spacing bug #30654

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
05a45be
fix ie logo bug
flash1293 Feb 11, 2019
1aa1f89
fix ie logo bug fix
flash1293 Feb 11, 2019
ac9d887
fix snapshot tests
flash1293 Feb 11, 2019
f7de891
Merge remote-tracking branch 'upstream/master' into fix/custom-logo-ie
flash1293 Feb 12, 2019
c989da1
address PR review
flash1293 Feb 12, 2019
a2cd5ef
fix snapshots
flash1293 Feb 12, 2019
ca9feb0
remove max height of preview image
flash1293 Feb 13, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions src/legacy/core_plugins/kibana/public/management/sections/settings/advanced_settings.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,19 @@

&Wrapper {
width: 640px;

@include internetExplorerOnly() {
min-height: 1px;
}
}

&Actions {
padding-top: $euiSizeM;
}

@include internetExplorerOnly {
&Row {
min-height: 1px;
}
}
}
32 changes: 32 additions & 0 deletions ...ana/public/management/sections/settings/components/field/__snapshots__/field.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,7 @@ exports[`Field for array setting should render as read only with help text if ov
titleSize="xs"
>
<EuiFormRow
className="mgtAdvancedSettings__fieldRow"
describedByIds={
Array [
"array:test:setting-aria",
Expand Down Expand Up @@ -158,6 +159,7 @@ exports[`Field for array setting should render custom setting icon if it is cust
titleSize="xs"
>
<EuiFormRow
className="mgtAdvancedSettings__fieldRow"
describedByIds={
Array [
"array:test:setting-aria",
Expand Down Expand Up @@ -231,6 +233,7 @@ exports[`Field for array setting should render default value if there is no user
titleSize="xs"
>
<EuiFormRow
className="mgtAdvancedSettings__fieldRow"
describedByIds={
Array [
"array:test:setting-aria",
Expand Down Expand Up @@ -327,6 +330,7 @@ exports[`Field for array setting should render user value if there is user value
titleSize="xs"
>
<EuiFormRow
className="mgtAdvancedSettings__fieldRow"
describedByIds={
Array [
"array:test:setting-aria",
Expand Down Expand Up @@ -442,6 +446,7 @@ exports[`Field for boolean setting should render as read only with help text if
titleSize="xs"
>
<EuiFormRow
className="mgtAdvancedSettings__fieldRow"
describedByIds={
Array [
"boolean:test:setting-aria",
Expand Down Expand Up @@ -541,6 +546,7 @@ exports[`Field for boolean setting should render custom setting icon if it is cu
titleSize="xs"
>
<EuiFormRow
className="mgtAdvancedSettings__fieldRow"
describedByIds={
Array [
"boolean:test:setting-aria",
Expand Down Expand Up @@ -618,6 +624,7 @@ exports[`Field for boolean setting should render default value if there is no us
titleSize="xs"
>
<EuiFormRow
className="mgtAdvancedSettings__fieldRow"
describedByIds={
Array [
"boolean:test:setting-aria",
Expand Down Expand Up @@ -718,6 +725,7 @@ exports[`Field for boolean setting should render user value if there is user val
titleSize="xs"
>
<EuiFormRow
className="mgtAdvancedSettings__fieldRow"
describedByIds={
Array [
"boolean:test:setting-aria",
Expand Down Expand Up @@ -837,6 +845,7 @@ exports[`Field for image setting should render as read only with help text if ov
titleSize="xs"
>
<EuiFormRow
className="mgtAdvancedSettings__fieldRow"
describedByIds={
Array [
"image:test:setting-aria",
Expand Down Expand Up @@ -929,6 +938,7 @@ exports[`Field for image setting should render custom setting icon if it is cust
titleSize="xs"
>
<EuiFormRow
className="mgtAdvancedSettings__fieldRow"
describedByIds={
Array [
"image:test:setting-aria",
Expand Down Expand Up @@ -1000,6 +1010,7 @@ exports[`Field for image setting should render default value if there is no user
titleSize="xs"
>
<EuiFormRow
className="mgtAdvancedSettings__fieldRow"
describedByIds={
Array [
"image:test:setting-aria",
Expand Down Expand Up @@ -1094,6 +1105,7 @@ exports[`Field for image setting should render user value if there is user value
titleSize="xs"
>
<EuiFormRow
className="mgtAdvancedSettings__fieldRow"
describedByIds={
Array [
"image:test:setting-aria",
Expand Down Expand Up @@ -1225,6 +1237,7 @@ exports[`Field for json setting should render as read only with help text if ove
titleSize="xs"
>
<EuiFormRow
className="mgtAdvancedSettings__fieldRow"
describedByIds={
Array [
"json:test:setting-aria",
Expand Down Expand Up @@ -1336,6 +1349,7 @@ exports[`Field for json setting should render custom setting icon if it is custo
titleSize="xs"
>
<EuiFormRow
className="mgtAdvancedSettings__fieldRow"
describedByIds={
Array [
"json:test:setting-aria",
Expand Down Expand Up @@ -1452,6 +1466,7 @@ exports[`Field for json setting should render default value if there is no user
titleSize="xs"
>
<EuiFormRow
className="mgtAdvancedSettings__fieldRow"
describedByIds={
Array [
"json:test:setting-aria",
Expand Down Expand Up @@ -1587,6 +1602,7 @@ exports[`Field for json setting should render user value if there is user value
titleSize="xs"
>
<EuiFormRow
className="mgtAdvancedSettings__fieldRow"
describedByIds={
Array [
"json:test:setting-aria",
Expand Down Expand Up @@ -1718,6 +1734,7 @@ exports[`Field for markdown setting should render as read only with help text if
titleSize="xs"
>
<EuiFormRow
className="mgtAdvancedSettings__fieldRow"
describedByIds={
Array [
"markdown:test:setting-aria",
Expand Down Expand Up @@ -1829,6 +1846,7 @@ exports[`Field for markdown setting should render custom setting icon if it is c
titleSize="xs"
>
<EuiFormRow
className="mgtAdvancedSettings__fieldRow"
describedByIds={
Array [
"markdown:test:setting-aria",
Expand Down Expand Up @@ -1918,6 +1936,7 @@ exports[`Field for markdown setting should render default value if there is no u
titleSize="xs"
>
<EuiFormRow
className="mgtAdvancedSettings__fieldRow"
describedByIds={
Array [
"markdown:test:setting-aria",
Expand Down Expand Up @@ -2030,6 +2049,7 @@ exports[`Field for markdown setting should render user value if there is user va
titleSize="xs"
>
<EuiFormRow
className="mgtAdvancedSettings__fieldRow"
describedByIds={
Array [
"markdown:test:setting-aria",
Expand Down Expand Up @@ -2161,6 +2181,7 @@ exports[`Field for number setting should render as read only with help text if o
titleSize="xs"
>
<EuiFormRow
className="mgtAdvancedSettings__fieldRow"
describedByIds={
Array [
"number:test:setting-aria",
Expand Down Expand Up @@ -2256,6 +2277,7 @@ exports[`Field for number setting should render custom setting icon if it is cus
titleSize="xs"
>
<EuiFormRow
className="mgtAdvancedSettings__fieldRow"
describedByIds={
Array [
"number:test:setting-aria",
Expand Down Expand Up @@ -2329,6 +2351,7 @@ exports[`Field for number setting should render default value if there is no use
titleSize="xs"
>
<EuiFormRow
className="mgtAdvancedSettings__fieldRow"
describedByIds={
Array [
"number:test:setting-aria",
Expand Down Expand Up @@ -2425,6 +2448,7 @@ exports[`Field for number setting should render user value if there is user valu
titleSize="xs"
>
<EuiFormRow
className="mgtAdvancedSettings__fieldRow"
describedByIds={
Array [
"number:test:setting-aria",
Expand Down Expand Up @@ -2540,6 +2564,7 @@ exports[`Field for select setting should render as read only with help text if o
titleSize="xs"
>
<EuiFormRow
className="mgtAdvancedSettings__fieldRow"
describedByIds={
Array [
"select:test:setting-aria",
Expand Down Expand Up @@ -2652,6 +2677,7 @@ exports[`Field for select setting should render custom setting icon if it is cus
titleSize="xs"
>
<EuiFormRow
className="mgtAdvancedSettings__fieldRow"
describedByIds={
Array [
"select:test:setting-aria",
Expand Down Expand Up @@ -2742,6 +2768,7 @@ exports[`Field for select setting should render default value if there is no use
titleSize="xs"
>
<EuiFormRow
className="mgtAdvancedSettings__fieldRow"
describedByIds={
Array [
"select:test:setting-aria",
Expand Down Expand Up @@ -2855,6 +2882,7 @@ exports[`Field for select setting should render user value if there is user valu
titleSize="xs"
>
<EuiFormRow
className="mgtAdvancedSettings__fieldRow"
describedByIds={
Array [
"select:test:setting-aria",
Expand Down Expand Up @@ -2987,6 +3015,7 @@ exports[`Field for string setting should render as read only with help text if o
titleSize="xs"
>
<EuiFormRow
className="mgtAdvancedSettings__fieldRow"
describedByIds={
Array [
"string:test:setting-aria",
Expand Down Expand Up @@ -3082,6 +3111,7 @@ exports[`Field for string setting should render custom setting icon if it is cus
titleSize="xs"
>
<EuiFormRow
className="mgtAdvancedSettings__fieldRow"
describedByIds={
Array [
"string:test:setting-aria",
Expand Down Expand Up @@ -3155,6 +3185,7 @@ exports[`Field for string setting should render default value if there is no use
titleSize="xs"
>
<EuiFormRow
className="mgtAdvancedSettings__fieldRow"
describedByIds={
Array [
"string:test:setting-aria",
Expand Down Expand Up @@ -3251,6 +3282,7 @@ exports[`Field for string setting should render user value if there is user valu
titleSize="xs"
>
<EuiFormRow
className="mgtAdvancedSettings__fieldRow"
describedByIds={
Array [
"string:test:setting-aria",
Expand Down
1 change: 1 addition & 0 deletions src/legacy/core_plugins/kibana/public/management/sections/settings/components/field/field.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -721,6 +721,7 @@ class FieldUI extends PureComponent {
label={this.renderLabel(setting)}
helpText={this.renderHelpText(setting)}
describedByIds={[`${setting.name}-aria`]}
className="mgtAdvancedSettings__fieldRow"
>
{this.renderField(setting)}
</EuiFormRow>
Expand Down