Fix dashboard links in Add Data UI #30860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaiyan-sheng
commented
Feb 12, 2019
| @@ -22,7 +22,7 @@ import { TUTORIAL_CATEGORY } from '../../../common/tutorials/tutorial_category'; | |||
| import { onPremInstructions, cloudInstructions, onPremCloudInstructions } from '../../../common/tutorials/filebeat_instructions'; | |||
|
|
|||
| export function apacheLogsSpecProvider(server, context) { | |||
| const moduleName = 'apache2'; | |||
There was a problem hiding this comment.
@ruflin when I'm fixing the links, I saw this. Should this be apache instead of apache2?
There was a problem hiding this comment.
Good catch, this should be apache.
kaiyan-sheng
added
Team:Beats
Team:Infra Monitoring UI - DEPRECATED
|
Pinging @elastic/beats |
ruflin
approved these changes
Feb 13, 2019
| }, | ||
| }), | ||
| euiIconType: 'logoApache', | ||
| artifacts: { | ||
| dashboards: [ | ||
| { | ||
| id: 'Filebeat-Apache2-Dashboard', | ||
| id: 'Filebeat-Apache-Dashboard-ecs', |
There was a problem hiding this comment.
Can you double check if we renamed the ID in the Beats repo for the dashboard?
There was a problem hiding this comment.
@ruflin Yeah I tested this and it works, also found the id name in filebeat https://github.com/elastic/beats/blob/master/filebeat/module/apache/_meta/kibana/7/dashboard/Filebeat-apache.json#L647
|
retest |
💚 Build Succeeded |
kaiyan-sheng
added a commit
to kaiyan-sheng/kibana
that referenced
this pull request
Feb 14, 2019
* Fix dashboard links in Add Data UI * Fix dashboard links in logging add data ui
kaiyan-sheng
added a commit
to kaiyan-sheng/kibana
that referenced
this pull request
Feb 14, 2019
* Fix dashboard links in Add Data UI * Fix dashboard links in logging add data ui
kaiyan-sheng
added a commit
that referenced
this pull request
Feb 16, 2019
kaiyan-sheng
added a commit
that referenced
this pull request
Feb 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Beats dashboard IDs were adjusted to not conflict with the 6.x dashboards so all the Add Data UI tutorials for Beats are broken. This PR is to update the links in kibana to fix Add Data UI when clicking for example
AWS metrics dashboard.closes #30805