[6.7] [Canvas] Adds doc links and keyboard shortcut cheatsheat to help menu (#31335) #31729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💔 Build Failed |
💔 Build Failed |
💔 Build Failed |
…elastic#31335) * Fixed tooltip in fullscreen_control * Removed aeroelastic keyboard event handlers * Added input target check to workpad page keyhandler * Fixed ungrouping * Removed tabIndex * Fix: reintroduce additional call on keyboard event
cqliu1
force-pushed
the
backport/6.7/pr-31335
branch
from
6313365 to
af4ad02
Compare
monfera
reviewed
Feb 22, 2019
There was a problem hiding this comment.
I might be wrong, but it looks like some files in the exluded commits have things that could be retained, eg. the key map 87bb9f7#diff-94893c7fdd2dc31a0bafdf3436a0fc7a - what do you think?
|
@monfera It'd be more accurate to say that I kept changes in specific files and deleted changes in others. Let me list the changes I specifically removed instead of which commits I kept/reverted bc that isn't completely accurate. The PR was squashed, so all the changes were in one commit, and I reset the commit and recommitted only the changed I wanted to keep. |
💔 Build Failed |
monfera
approved these changes
Feb 22, 2019
💚 Build Succeeded |
💚 Build Succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports the following commits to 6.7:
This is a partial backport. The UI changes made in 6.7 to the global nav can't be backported, but all of the keyboard event handling and shortcut changes will be backported. This backport removes changes related to the global nav:
HelpMenuandKeyboardShortcutsDoccomponentspublic/app.jsthat addHelpMenuto the global navWorkpadManagergetClientPlatformpublic lib functionAll other changes not listed above were retained in this backport.