[logging] Corrects intercept of ECONNRESET

[tylersmalley]

errno is not set for ECONNRESET

https://github.com/hapijs/wreck/blob/29d8f4b5eaa12c5d44c642130cd6002c1d83ffd2/lib/index.js#L290

Closes #22225

Testing:

• Start Kibana with SSL: yarn start --ssl
• Refresh the page before the page has fully loaded.

Example:

{ Error: socket hang up
  at TLSSocket.onSocketClose (_tls_wrap.js:761:23)
  at TLSSocket.emit (events.js:194:15)
  at _handle.close (net.js:600:12)
  at Socket.done (_tls_wrap.js:388:7)
  at Object.onceWrapper (events.js:277:13)
  at Socket.emit (events.js:189:13)
  at TCP._handle.close (net.js:600:12) code: 'ECONNRESET'

[elasticmachine]

Pinging @elastic/kibana-operations

[tylersmalley]

@joshdover do you know if we would ever expect a ECONNRESET for errno where code was also not supplied?

[tylersmalley]

@jbudz, you might also have some thoughts on this.

[tylersmalley]

Actually wondering if we should just be checking for both errno and code

[tylersmalley]

retest

[mistic]

I think errno is a special property only available for NodeJS SystemError (which inherits from Error). Maybe we can just checking for code on errors, or at least if we want to be cautious, maybe implement what you suggested of checking both for errno and code but maybe giving priority to the code property. What do u think @tylersmalley ?

[jbudz]

Yea I think we'll want both - I believe the other scenario that @mistic mentioned is https://github.com/hapijs/hapi/blob/v16/lib/connection.js#L94.

[tylersmalley]

Updated to check both code and errno.

[mistic]

retest

[tylersmalley]

Failed test should be fixed with: #31830

[elasticmachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request