Fix Dashboard Save tests #32112
Merged
Fix Dashboard Save tests #32112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ard popup behaviour
💔 Build Failed |
💚 Build Succeeded |
|
retest |
💚 Build Succeeded |
|
retest |
💚 Build Succeeded |
cuff-links
approved these changes
Feb 27, 2019
spalger
pushed a commit
that referenced
this pull request
Mar 2, 2019
* Restore webdriver-based functional test runner driver * run all function test suites 6 times per build, to help spot flakiness * [tests/reporting] fix flaky click on report generation * [#31446] stabilize x-pack-ciGroup6 (#31447) * rerun x-pack-ciGroup6 40 times * improve reporting tests stability (#31454) * Revert "rerun x-pack-ciGroup6 40 times" This reverts commit 63026b1. * Fix Dashboard Save tests (#32112) * [page_objects/dashboard_page] add waitDialogIsClosed to manage dashboard popup behaviour * [page_objects/dashboard_page] add waitDialogIsClosed flag * services: leadfoot -> webdriver * [services/lib/web_element_wrapper] extend type with charByChar input (#32305) * Revert "run all function test suites 6 times per build, to help spot flakiness" This reverts commit 4770993.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a flag
waitDialogIsClosedto manage ifDashboard Savedialog should be closed or not.To stabilize reporting tests I added waiting for the dialog to dissappear from DOM:
await testSubjects.waitForDeleted(modalDialog);It was a breaking change for several
dashboard savetests expecting dialog to remain displayed.Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.- [ ] This was checked for cross-browser compatibility, including a check against IE11- [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes i18n support- [ ] Documentation was added for features that require explanation or tutorials- [ ] This was checked for keyboard-only and screenreader accessibilityFor maintainers
- [ ] This was checked for breaking API changes and was labeled appropriately- [ ] This includes a feature addition or change that requires a release note and was labeled appropriately