Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve app management tests #32255

Closed

Conversation

dmlemeshko
Copy link
Member

@dmlemeshko dmlemeshko commented Feb 28, 2019

Summary

Another failure we got in #31446

"Create Index Pattern" wizard test has been flaky on inputting index pattern field:

Error: expected 'lgstash-*o' to sort of equal 'logstash-*'

kibana failing tests - kibana 2019-02-28 22-40-53

I added charBychar:boolean option to type function, to input characters 1 by 1 with 100ms delay if it is set true

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

- [ ] This was checked for cross-browser compatibility, including a check against IE11
- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
- [ ] Documentation was added for features that require explanation or tutorials

For maintainers

- [ ] This was checked for breaking API changes and was labeled appropriately
- [ ] This includes a feature addition or change that requires a release note and was labeled appropriately

@elasticmachine
Copy link
Contributor

💔 Build Failed

@dmlemeshko dmlemeshko requested review from LeeDr and spalger February 28, 2019 22:40
@dmlemeshko
Copy link
Member Author

I was not able to run kibana-ciGroup7 in 30 threads with Jenkins, lets see how the regular build goes.

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@dmlemeshko
Copy link
Member Author

retest

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@spalger
Copy link
Contributor

spalger commented Mar 5, 2019

LGTM, but we should update this to use webdriver

# Conflicts:
#	test/functional/services/lib/leadfoot_element_wrapper/leadfoot_element_wrapper.js
@spalger
Copy link
Contributor

spalger commented Mar 5, 2019

Welp, merged master and this no longer has any changes... Guess this made it into the webdriver PR

@spalger spalger closed this Mar 5, 2019
@cuff-links
Copy link
Contributor

That's hilarious. I was waiting for that merger to do a review.

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@dmlemeshko dmlemeshko deleted the improve-app-management-tests branch April 22, 2019 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants