-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
replacing Angular watch list UI with React one #32401
Merged
Merged
Changes from 4 commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
f258d35
replacing Angular watch list UI with React one
bmcconaghy 7612d09
fixing TS issues
bmcconaghy 3e2e1ce
addressing PR feedback
bmcconaghy 00c5019
fixing TS issues
bmcconaghy 54930a3
more TS fixes
bmcconaghy ffe45b7
TS fix
bmcconaghy e6cd294
addressing more PR feedback
bmcconaghy 91f8ce7
TS fixes
bmcconaghy 1876c2f
removing unused/incompatible translations
bmcconaghy acdf987
fixing functional test
bmcconaghy 633889b
prettier fix
bmcconaghy 322f0da
fixing typp
bmcconaghy 38c85d1
fixing missing comma
bmcconaghy ba86b1f
fixing data-test-subject typo
bmcconaghy 1f5d4ad
fixing functional test
bmcconaghy 167b762
fixing functional tests
bmcconaghy 47efebf
fixing delete functional tests
bmcconaghy ae4d80e
Merge remote-tracking branch 'upstream/watcher-port' into watcher-port
bmcconaghy 52ee52d
addressing PR feedback
bmcconaghy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
33 changes: 0 additions & 33 deletions
33
x-pack/plugins/watcher/common/constants/watch_state_comments.js
This file was deleted.
Oops, something went wrong.
46 changes: 46 additions & 0 deletions
46
x-pack/plugins/watcher/common/constants/watch_state_comments.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,46 @@ | ||
/* | ||
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
* or more contributor license agreements. Licensed under the Elastic License; | ||
* you may not use this file except in compliance with the Elastic License. | ||
*/ | ||
|
||
import { i18n } from '@kbn/i18n'; | ||
|
||
export const WATCH_STATE_COMMENTS: { [key: string]: string } = { | ||
OK: '', | ||
|
||
PARTIALLY_THROTTLED: i18n.translate( | ||
'xpack.watcher.constants.watchStateComments.partiallyThrottledStateCommentText', | ||
{ | ||
defaultMessage: 'Partially throttled', | ||
} | ||
), | ||
|
||
THROTTLED: i18n.translate( | ||
'xpack.watcher.constants.watchStateComments.throttledStateCommentText', | ||
{ | ||
defaultMessage: 'Throttled', | ||
} | ||
), | ||
|
||
PARTIALLY_ACKNOWLEDGED: i18n.translate( | ||
'xpack.watcher.constants.watchStateComments.partiallyAcknowledgedStateCommentText', | ||
{ | ||
defaultMessage: 'Partially acked', | ||
} | ||
), | ||
|
||
ACKNOWLEDGED: i18n.translate( | ||
'xpack.watcher.constants.watchStateComments.acknowledgedStateCommentText', | ||
{ | ||
defaultMessage: 'Acked', | ||
} | ||
), | ||
|
||
FAILING: i18n.translate( | ||
'xpack.watcher.constants.watchStateComments.executionFailingStateCommentText', | ||
{ | ||
defaultMessage: 'Execution failing', | ||
} | ||
), | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typescript string-based enums (https://www.typescriptlang.org/docs/handbook/enums.html) are normally used for these list of constant values.