Typescript-ify FTR Remote #32447
Merged
Typescript-ify FTR Remote #32447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💔 Build Failed |
💚 Build Succeeded |
💔 Build FailedTwo chromedriver install failures 🦊 |
💚 Build Succeeded |
|
LGTM. Tested locally |
dmlemeshko
approved these changes
Mar 6, 2019
spalger
pushed a commit
to spalger/kibana
that referenced
this pull request
Mar 6, 2019
* [ftr] flatten GenericProviderTypes to fix "log" types * [ftr/remote] typscript-ify * remove webdriver types, since they're version 3 and we're using version 4 * simplify initWebDriver() function * keep jest tests in the functional tests as js, mixing jest and mocha types doesn't work # Conflicts: # yarn.lock
spalger
pushed a commit
that referenced
this pull request
Mar 6, 2019
|
7.x/7.1: 71b1b60 |
PhilippBaranovskiy
pushed a commit
to PhilippBaranovskiy/kibana
that referenced
this pull request
Mar 7, 2019
* [ftr] flatten GenericProviderTypes to fix "log" types * [ftr/remote] typscript-ify * remove webdriver types, since they're version 3 and we're using version 4 * simplify initWebDriver() function * keep jest tests in the functional tests as js, mixing jest and mocha types doesn't work
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for the Percy integration I'd like to have a couple more services in TypeScript.