[ML] (Accessibility) "Analyzing Data" should announce #32472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
|
retest |
1 similar comment
|
retest |
💔 Build Failed |
|
retest |
💚 Build Succeeded |
|
Pinging @elastic/ml-ui |
peteharverson
requested changes
Mar 6, 2019
There was a problem hiding this comment.
If you can make the change I suggested @rockfield I can go ahead and merge this to master, and then backport to 7.x, 7.0. Many thanks for looking at this one!
x-pack/plugins/ml/public/file_datavisualizer/components/about_panel/about_panel.js
Outdated
Show resolved
Hide resolved
💔 Build Failed |
|
retest |
💔 Build Failed |
|
retest |
💔 Build Failed |
💚 Build Succeeded |
PhilippBaranovskiy
added a commit
to PhilippBaranovskiy/kibana
that referenced
this pull request
Mar 7, 2019
* [ML] (Accessibility) "Analyzing Data" should announce * moved aria role to the header tag
PhilippBaranovskiy
added a commit
to PhilippBaranovskiy/kibana
that referenced
this pull request
Mar 7, 2019
* [ML] (Accessibility) "Analyzing Data" should announce * moved aria role to the header tag
PhilippBaranovskiy
added a commit
that referenced
this pull request
Mar 7, 2019
PhilippBaranovskiy
added a commit
that referenced
this pull request
Mar 7, 2019
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FIX: #31111
Summary
Now the "Analyzing data" popup pronouns itself with ScreenReader by using ScreenReaderOnly component from eUI.
Tested with ChromeVox.