[Maps] replace angular serviceSettings service with EmsClient #32725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nreese
added
chore
[Deprecated-Use Team:Presentation]Team:Geo
|
Pinging @elastic/kibana-gis |
thomasneirynck
approved these changes
Mar 7, 2019
💔 Build Failed |
💚 Build Succeeded |
nreese
added a commit
to nreese/kibana
that referenced
this pull request
Mar 8, 2019
…c#32725) * [Maps] replace angular serviceSettings service with EmsClient * clean up
nreese
added a commit
that referenced
this pull request
Mar 8, 2019
#32731) * [Maps] replace angular serviceSettings service with EmsClient * clean up
nreese
added
the
non-issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a refactor PR that does not provide any new functionality.
The maps application was using the legacy angular service
serviceSettingsto get the EMS vector layer URL. This PR replaces the need for usingserviceSettingsby just putting the emsLink in the response returned from the meta REST endpoint.