[reporting/autoDownload] default to true when not in distributable #32803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spalger
added
review
v7.0.0
(Deprecated) Feature:Reporting
|
LGTM |
joelgriffith
approved these changes
Mar 8, 2019
|
x-pack intake tests passed, merging to get 7.0 green again |
spalger
pushed a commit
to spalger/kibana
that referenced
this pull request
Mar 8, 2019
spalger
pushed a commit
to spalger/kibana
that referenced
this pull request
Mar 8, 2019
This was referenced Mar 8, 2019
spalger
pushed a commit
to spalger/kibana
that referenced
this pull request
Mar 8, 2019
…lastic#32803) # Conflicts: # x-pack/plugins/reporting/index.js
💚 Build Succeeded |
spalger
pushed a commit
that referenced
this pull request
Mar 8, 2019
spalger
pushed a commit
that referenced
this pull request
Mar 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We removed the bootstrap cache from 7.0 in #32782, which the tests were relying on to provide the chromium artifacts. Reporting wasn't automatically downloading them as we expected because the tests are running the Kibana server in production mode, and that config was off by default in production mode, so instead we've based the auto-download behavior on whether or not we are running the distributable, which should always have the browsers available anyway.
This PR targets 7.0, because that's where CI is failing right now, but I'll forward/backport this to the necessary branches once it is in.