Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrades EUI to 9.5 #33672

Merged
merged 4 commits into from
Mar 22, 2019
Merged

Upgrades EUI to 9.5 #33672

merged 4 commits into from
Mar 22, 2019

Conversation

jasonrhodes
Copy link
Member

Summary

Upgrades EUI to 9.5 and fixes any associated breaks.

https://github.com/elastic/eui/blob/master/CHANGELOG.md#950

@elasticmachine
Copy link
Contributor

💔 Build Failed

@jasonrhodes jasonrhodes marked this pull request as ready for review March 21, 2019 20:54
@jasonrhodes jasonrhodes requested a review from a team as a code owner March 21, 2019 20:54
@elasticmachine
Copy link
Contributor

💔 Build Failed

@joelgriffith
Copy link
Contributor

Looks like Snapshot failure, going to try and push up fixes.

@jasonrhodes jasonrhodes requested review from a team as code owners March 21, 2019 22:00
@jasonrhodes
Copy link
Member Author

Just pushed up the x-pack snapshot failures which should be the last of the updates needed. I'm signing off now so if anyone else wants to pick up from there, feel free. :)

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

walterra
walterra approved these changes Mar 22, 2019
View reviewed changes
Copy link
Contributor

@walterra walterra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

iconType related changes LGTM. Just a more general EUI related thought: Would it make sense if EUI exported an Enum with the iconType names? Then you could do something like iconTypeEnum.search instead of 'search' as IconType.

sorenlouv
sorenlouv approved these changes Mar 22, 2019
View reviewed changes
Copy link
Member

@sorenlouv sorenlouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweeet!

joshdover
joshdover approved these changes Mar 22, 2019
View reviewed changes
Copy link
Contributor

@joshdover joshdover left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tiny core change lgtm

@jasonrhodes jasonrhodes merged commit 721161f into elastic:master Mar 22, 2019
@jasonrhodes jasonrhodes deleted the update-eui-to-9.5 branch March 22, 2019 14:28
@joelgriffith
Copy link
Contributor

size="m" nice!

snide pushed a commit to snide/kibana that referenced this pull request Mar 28, 2019
@jasonrhodes @snide
Upgrades EUI to 9.5 (elastic#33672)
82c7ace 
* Updates EUI to 9.5.0

* Remove duplicate type

* Updates snapshots and fixes a few type errors

* Updates x-pack snapshots
@snide snide mentioned this pull request Mar 28, 2019
Merged
snide added a commit that referenced this pull request Mar 28, 2019
@snide
[7.x] EUI catchup to 9.7.1 (#34124)
43db4ef 
* Upgrades EUI to 9.5 (#33672)

* Updates EUI to 9.5.0

* Remove duplicate type

* Updates snapshots and fixes a few type errors

* Updates x-pack snapshots

* Upgrade EUI to 9.6.0 (#33873)

* eui to 9.6.0

* update snapshots related to onClick

* EUI@9.7.0 (#34011)

* eui 9.7.1 (#34098)

* snaps
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshdover joshdover joshdover approved these changes

@kobelb kobelb kobelb approved these changes

@walterra walterra walterra approved these changes

@sorenlouv sorenlouv sorenlouv approved these changes

@joelgriffith joelgriffith Awaiting requested review from joelgriffith

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@jasonrhodes @elasticmachine @joelgriffith @sorenlouv @walterra @kobelb @joshdover