-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TSVB] Fix Rollup Search with auto interval for Rollup Jobs in calendar intervals #36081
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexwizp
changed the title
Auto interval
Rollup Search - 'auto' interval is not working for Rollup Jobs which were created in Calendar intervals
May 4, 2019
… which were created in Calendar intervals
… which were created in Calendar intervals
💔 Build Failed |
💚 Build Succeeded |
lukeelmers
added
the
Team:Visualizations
Visualization editors, elastic-charts and infrastructure
label
May 7, 2019
Pinging @elastic/kibana-app |
💔 Build Failed |
💚 Build Succeeded |
alexwizp
added
the
release_note:skip
Skip the PR/issue when compiling release notes
label
May 13, 2019
💚 Build Succeeded |
gospodarsky
reviewed
May 17, 2019
src/legacy/core_plugins/metrics/public/components/vis_editor_visualization.js
Outdated
Show resolved
Hide resolved
src/legacy/core_plugins/metrics/public/components/vis_editor_visualization.js
Outdated
Show resolved
Hide resolved
gospodarsky
reviewed
May 17, 2019
src/legacy/core_plugins/metrics/server/lib/vis_data/helpers/unit_to_seconds.js
Show resolved
Hide resolved
src/legacy/core_plugins/metrics/server/lib/vis_data/helpers/unit_to_seconds.js
Outdated
Show resolved
Hide resolved
src/legacy/core_plugins/metrics/server/lib/vis_data/helpers/unit_to_seconds.js
Show resolved
Hide resolved
src/legacy/core_plugins/metrics/server/lib/vis_data/helpers/unit_to_seconds.test.js
Outdated
Show resolved
Hide resolved
💚 Build Succeeded |
gospodarsky
approved these changes
May 20, 2019
Looks good to me. |
7 tasks
markov00
changed the title
Rollup Search - 'auto' interval is not working for Rollup Jobs which were created in Calendar intervals
[TSVB] Fix Rollup Search with auto interval for Rollup Jobs in calendar intervals
May 23, 2019
alexwizp
added a commit
to alexwizp/kibana
that referenced
this pull request
May 24, 2019
…ar intervals (elastic#36081) * auto interval * [TSVB] Rollup Search - 'auto' interval is not working for Rollup Jobs which were created in Calendar intervals * [TSVB] Rollup Search - 'auto' interval is not working for Rollup Jobs which were created in Calendar intervals * fix issue * fix broken tests * fix pr comments * fix pr comments
alexwizp
added a commit
to alexwizp/kibana
that referenced
this pull request
May 24, 2019
…ar intervals (elastic#36081) * auto interval * [TSVB] Rollup Search - 'auto' interval is not working for Rollup Jobs which were created in Calendar intervals * [TSVB] Rollup Search - 'auto' interval is not working for Rollup Jobs which were created in Calendar intervals * fix issue * fix broken tests * fix pr comments * fix pr comments
alexwizp
added a commit
that referenced
this pull request
May 24, 2019
…ar intervals (#36081) (#37067) * auto interval * [TSVB] Rollup Search - 'auto' interval is not working for Rollup Jobs which were created in Calendar intervals * [TSVB] Rollup Search - 'auto' interval is not working for Rollup Jobs which were created in Calendar intervals * fix issue * fix broken tests * fix pr comments * fix pr comments
alexwizp
added a commit
that referenced
this pull request
May 24, 2019
…ar intervals (#36081) (#37066) * auto interval * [TSVB] Rollup Search - 'auto' interval is not working for Rollup Jobs which were created in Calendar intervals * [TSVB] Rollup Search - 'auto' interval is not working for Rollup Jobs which were created in Calendar intervals * fix issue * fix broken tests * fix pr comments * fix pr comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Feature:TSVB
TSVB (Time Series Visual Builder)
release_note:skip
Skip the PR/issue when compiling release notes
Team:Visualizations
Visualization editors, elastic-charts and infrastructure
v7.2.0
v8.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #36080
Summary
Rollup Search - 'auto' interval is not working for Rollup Jobs which were created in Calendar intervals
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.For maintainers