Fix sorting of Monitoring nodes on CPU, Throttle, Heap columns #36125
Conversation
igoristic
added
bug
|
Pinging @elastic/stack-monitoring |
cjcenizal
changed the title
|
CC @chandlerprall @thompsongl Maybe there's a way to improve the EUI docs regarding this feature? |
💔 Build Failed |
💔 Build Failed |
@cjcenizal I created elastic/eui#1919. Feel free to add ideas or specific difficulties to that thread |
💔 Build Failed |
💔 Build Failed |
💔 Build Failed |
💔 Build Failed |
💔 Build Failed |
💔 Build Failed |
💚 Build Succeeded |
|
|
||
| const getSortHandler = (type) => (item) => _.get(item, `${type}.summary.lastVal`); |
There was a problem hiding this comment.
I don't know why, but for this some reason, this isn't working for me.
const getSortHandler = (type) => (item) => _.get(item, [type, 'summary', 'lastVal']);
This does work for me and I don't know why. Can you confirm/deny?
There was a problem hiding this comment.
Bump @igoristic. It would be great if we could get this resolved and then this fix merged. Thanks!
There was a problem hiding this comment.
Update: I didn't closely read the time stamp here and left the impression that this is urgent when it's not. Apologies if it came across like I was pushing for this to be done. It will be fine whenever you get to it. Thanks!
|
@igoristic I see you added the I assume you plan to backport this fix to the At any rate, the |
💚 Build Succeeded |
…ic#36125) * Complete rebase * Testing * Retest * Made the get method more compatible
… (#37011) * Complete rebase * Testing * Retest * Made the get method more compatible
…ic#36125) * Complete rebase * Testing * Retest * Made the get method more compatible
… (#43615) * Complete rebase * Testing * Retest * Made the get method more compatible
Summary
Resolves #36038
This feature: elastic/eui#929 is not really well documented, but it allows us to add sorting on values instead of object.
I checked all the tables in
/monitoring/*and this was the only affected tableChecklist