[Code] refactor launcher code, add unit tests #36863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💔 Build Failed |
💔 Build Failed |
spacedragon
force-pushed
the
launcher_refactor
branch
from
0ba7abc to
d7c5aee
Compare
💚 Build Succeeded |
mw-ding
approved these changes
May 22, 2019
| * you may not use this file except in compliance with the Elastic License. | ||
| */ | ||
| /* eslint-disable */ | ||
| // This file is used in the test, using subprocess.fork to load a module directly, so this module can not be typescript |
| server.close(); | ||
| this.eventEmitter.emit('connect'); | ||
| socket.on('close', () => this.onSocketClosed()); | ||
| if (!this.connectingPromise) { |
There was a problem hiding this comment.
nit: so this tries to dedup the connection promises, right? can we leave some comment on here on what issue it solves.
| } | ||
| const log: Logger = this.loggerFactory.getLogger(['code', `ts@${this.targetHost}:${port}`]); | ||
| const proxy = new LanguageServerProxy(port, this.targetHost, log, this.options.lsp); | ||
| return 2089; |
There was a problem hiding this comment.
nit: maybe a const at the beginning of this class instead of a hard-wired value.
spacedragon
force-pushed
the
launcher_refactor
branch
from
d7c5aee to
6dcda9d
Compare
💚 Build Succeeded |
|
Tested locally on java language server. |
spacedragon
pushed a commit
to spacedragon/kibana
that referenced
this pull request
May 24, 2019
spacedragon
pushed a commit
that referenced
this pull request
May 24, 2019
spacedragon
pushed a commit
to spacedragon/kibana
that referenced
this pull request
May 31, 2019
spacedragon
pushed a commit
that referenced
this pull request
May 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Refactor launcher code, add unit tests
https://github.com/elastic/code/issues/1182
https://github.com/elastic/code/issues/1167
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.For maintainers