[Vis: Default editor] EUIficate IP Ranges #36896

maryia-lapata · 2019-05-22T15:53:01Z

Summary

EUIfication of IP Ranges control for aggregation parameter in Default Editor, Data tab.
Part of #30922.

Steps to reproduce: create Data Table visualization, choose IPv4 Range aggregation in Buckets group.

Details

If there is no default value defined in the config, it will be set the following default values: { from: '0.0.0.0', to: '255.255.255.255'} and { mask: '0.0.0.0/1' }
If a user doesn't set a value, it will be * by default.

This PR also contains removing unused directives: validateIp and validateCidrMask.

Screenshots:

From/To

--
2) CIDR mask

From/To with default value

From/To validation

CIDR mask with default value

Checklist

Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.

~~[ ] This was checked for cross-browser compatibility, including a check against IE11~~
Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
~~[ ] Documentation was added for features that require explanation or tutorials~~
Unit or functional tests were updated or added to match the most common scenarios
This was checked for keyboard-only and screenreader accessibility

For maintainers

~~[ ] This was checked for breaking API changes and was labeled appropriately~~
~~[ ] This includes a feature addition or change that requires a release note and was labeled appropriately~~

elasticmachine · 2019-05-24T15:33:39Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

elasticmachine · 2019-05-27T07:58:42Z

Pinging @elastic/kibana-app

elasticmachine · 2019-05-27T08:21:06Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

maryia-lapata · 2019-05-31T09:06:53Z

@kertal I created a PR with fix for not clickable button with svg: elastic/eui#1985

elasticmachine · 2019-05-31T09:11:15Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

wylieconlon

Functionality LGTM, but I'd like more type safety in the spot I mentioned. We should be avoiding any types.

wylieconlon · 2019-05-31T17:03:20Z

src/legacy/ui/public/agg_types/controls/components/input_list.tsx

+
+export type InputModel =
+  | InputModelBase & { [model: string]: InputItem }
+  | InputModelBase & InputItem;


This type is currently meaningless for the reason above- the union of [key: string]: any and anything else allows all values.

I unified Mask and FromTo models and updated InputModel definition. Please take a look.

src/legacy/ui/public/agg_types/controls/components/input_list.tsx

kertal

There seems to be a problem at CIDR mask validation, 0.0.0.0/123d validates correctly

elasticmachine · 2019-06-03T10:06:23Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

maryia-lapata · 2019-06-03T12:09:59Z

There seems to be a problem at CIDR mask validation, 0.0.0.0/123d validates correctly

@kertal thank you for noticing, it was a bug in initial version of CidrMask class. I fixed it.

elasticmachine · 2019-06-03T13:18:33Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

kertal

Thank you for the fixes, Code LGTM, tested in Chrome / Firefox. We should test it again in Safari/IE11 when your EUI fix is released

* Create IpRangeType and IpRanges controls * Add validation * Refactoring * Add behavior when discarding changes * Refactoring: create common input list * Remove old template * Move add btn to input_list, add placeholder * Remove unused directives * Remove unused translations * Refactoring * Use EuiButtonGroup instead of toggle button * Update options ids, add aria-labels * Remove unused translations * Update mask model, update TS, update aria labels * Add validation for CIRD mask

sulemanof

Great 👍

maryia-lapata added 7 commits May 20, 2019 10:01

Create IpRangeType and IpRanges controls

74097dd

Add validation

0f2abdc

Merge branch 'master' into vis-editor-ip-ranges

6e19ab3

Refactoring

b84928d

Add behavior when discarding changes

8c130cd

Refactoring: create common input list

5faa3d1

Remove old template

5d358c1

This comment has been minimized.

Sign in to view

maryia-lapata added 4 commits May 24, 2019 13:47

Merge branch 'master' into vis-editor-ip-ranges

d8b582a

Move add btn to input_list, add placeholder

702d5b3

Remove unused directives

fc4d91e

Remove unused translations

fb73c67

This comment has been minimized.

Sign in to view

maryia-lapata added 2 commits May 27, 2019 10:10

Merge branch 'master' into vis-editor-ip-ranges

d036e78

Refactoring

c0e269a

maryia-lapata requested a review from sulemanof May 27, 2019 07:58

maryia-lapata added Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Vis Editor Visualization editor issues v7.3.0 v8.0.0 labels May 27, 2019

timroes mentioned this pull request May 27, 2019

EUIficate vis editor data panel #30922

Closed

29 tasks

maryia-lapata marked this pull request as ready for review May 27, 2019 15:05

maryia-lapata requested a review from cchaos May 27, 2019 15:05

maryia-lapata added review release_note:skip Skip the PR/issue when compiling release notes labels May 28, 2019

kertal self-requested a review May 28, 2019 06:38

maryia-lapata requested a review from alexwizp May 28, 2019 07:58

Merge branch 'master' into vis-editor-ip-ranges

16a8d1a

maryia-lapata mentioned this pull request May 31, 2019

Fix not clickable button with svg in Safari elastic/eui#1985

Merged

10 tasks

maryia-lapata requested review from kertal, wylieconlon, chrisdavies and flash1293 May 31, 2019 09:07

wylieconlon approved these changes May 31, 2019

View reviewed changes

maryia-lapata added 2 commits June 3, 2019 09:52

Merge branch 'master' into vis-editor-ip-ranges

65f29b4

Update mask model, update TS, update aria labels

e8b711d

kertal requested changes Jun 3, 2019

View reviewed changes

Add validation for CIRD mask

640d075

kertal self-requested a review June 3, 2019 14:28

kertal approved these changes Jun 3, 2019

View reviewed changes

maryia-lapata merged commit b5c7520 into elastic:master Jun 4, 2019

maryia-lapata deleted the vis-editor-ip-ranges branch June 4, 2019 09:04

maryia-lapata mentioned this pull request Jun 4, 2019

[7.x] [Vis: Default editor] EUIficate IP Ranges (#36896) #37966

Merged

maryia-lapata added backported and removed review labels Jun 4, 2019

sulemanof reviewed Jun 7, 2019

View reviewed changes

maryia-lapata mentioned this pull request Jun 17, 2019

Vis editor: make IP Ranges inputs compressed #37476

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Vis: Default editor] EUIficate IP Ranges #36896

[Vis: Default editor] EUIficate IP Ranges #36896

maryia-lapata commented May 22, 2019 •

edited

Loading

This comment has been minimized.

This comment has been minimized.

elasticmachine commented May 24, 2019

elasticmachine commented May 27, 2019

elasticmachine commented May 27, 2019

maryia-lapata commented May 31, 2019

elasticmachine commented May 31, 2019

wylieconlon left a comment

wylieconlon May 31, 2019

maryia-lapata Jun 3, 2019

kertal left a comment

elasticmachine commented Jun 3, 2019

maryia-lapata commented Jun 3, 2019

elasticmachine commented Jun 3, 2019

kertal left a comment

sulemanof left a comment •

edited

Loading

[Vis: Default editor] EUIficate IP Ranges #36896

[Vis: Default editor] EUIficate IP Ranges #36896

Conversation

maryia-lapata commented May 22, 2019 • edited Loading

Summary

Details

Screenshots:

Checklist

For maintainers

This comment has been minimized.

This comment has been minimized.

elasticmachine commented May 24, 2019

💚 Build Succeeded

elasticmachine commented May 27, 2019

elasticmachine commented May 27, 2019

💚 Build Succeeded

maryia-lapata commented May 31, 2019

elasticmachine commented May 31, 2019

💚 Build Succeeded

wylieconlon left a comment

Choose a reason for hiding this comment

wylieconlon May 31, 2019

Choose a reason for hiding this comment

maryia-lapata Jun 3, 2019

Choose a reason for hiding this comment

kertal left a comment

Choose a reason for hiding this comment

elasticmachine commented Jun 3, 2019

💚 Build Succeeded

maryia-lapata commented Jun 3, 2019

elasticmachine commented Jun 3, 2019

💚 Build Succeeded

kertal left a comment

Choose a reason for hiding this comment

sulemanof left a comment • edited Loading

Choose a reason for hiding this comment

maryia-lapata commented May 22, 2019 •

edited

Loading

sulemanof left a comment •

edited

Loading