Fix formatdate not allowing strings #37301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clintandrewhall
added
review
Team:Presentation
|
Pinging @elastic/kibana-canvas |
clintandrewhall
added
the
release_note:skip
💔 Build Failed |
cqliu1
requested changes
May 29, 2019
|
@ryankeairns Could you approve the new |
cqliu1
approved these changes
May 29, 2019
💚 Build Succeeded |
clintandrewhall
added
the
bug
clintandrewhall
added a commit
to clintandrewhall/kibana
that referenced
this pull request
May 29, 2019
* Fix formatdate not allowing strings * Addressing Feedback
clintandrewhall
added a commit
that referenced
this pull request
May 29, 2019
jkakavas
pushed a commit
to jkakavas/kibana
that referenced
this pull request
May 30, 2019
* Fix formatdate not allowing strings * Addressing Feedback
clintandrewhall
added a commit
to clintandrewhall/kibana
that referenced
this pull request
Jun 6, 2019
* Fix formatdate not allowing strings * Addressing Feedback
clintandrewhall
added a commit
that referenced
this pull request
Jun 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
@alexfrancoeur noticed that
formatdatewas claiming a GMT date string wasn't a valid date. It turns out, whileformatdateis usingmomentunder the hood, the function spec wasn't allowing a string as an input.This PR fixes that issue.
Before
After