Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: handle null argument values #37411

Merged
merged 1 commit into from
May 29, 2019

Conversation

w33ble
Copy link
Contributor

@w33ble w33ble commented May 29, 2019

Fixes filterGroup parsing code. If you use a null, it'll crash Kibana.

typeof null === 'object', so this PR adds an explicit check for null.

Previous to this PR, this expression would crash Kibana:

Screenshot 2019-05-29 14 32 00

Props to @cqliu1 for finding this bug.

typeof null === 'object', so add an explicit check for null
@w33ble w33ble added bug Fixes for quality problems that affect the customer experience review Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas loe:small Small Level of Effort v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.2.0 v7.3.0 labels May 29, 2019
@w33ble w33ble requested a review from cqliu1 May 29, 2019 21:33
@w33ble w33ble requested a review from a team as a code owner May 29, 2019 21:33
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-canvas

@w33ble w33ble added the impact:critical This issue should be addressed immediately due to a critical level of impact on the product. label May 29, 2019
Copy link
Contributor

@cqliu1 cqliu1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Kibana was crashing when passing null to any unnamed arguments. Confirmed that those elements no longer crash the app.

@w33ble w33ble merged commit c4c1377 into elastic:master May 29, 2019
w33ble added a commit to w33ble/kibana that referenced this pull request May 29, 2019
typeof null === 'object', so add an explicit check for null
w33ble added a commit to w33ble/kibana that referenced this pull request May 29, 2019
typeof null === 'object', so add an explicit check for null
w33ble added a commit that referenced this pull request May 29, 2019
typeof null === 'object', so add an explicit check for null
w33ble added a commit that referenced this pull request May 29, 2019
typeof null === 'object', so add an explicit check for null
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

dgieselaar pushed a commit to dgieselaar/kibana that referenced this pull request May 30, 2019
typeof null === 'object', so add an explicit check for null
jkakavas pushed a commit to jkakavas/kibana that referenced this pull request May 30, 2019
typeof null === 'object', so add an explicit check for null
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience impact:critical This issue should be addressed immediately due to a critical level of impact on the product. loe:small Small Level of Effort release_note:skip Skip the PR/issue when compiling release notes review Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v7.2.0 v7.3.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants