-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: handle null argument values #37411
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typeof null === 'object', so add an explicit check for null
w33ble
added
bug
Fixes for quality problems that affect the customer experience
review
Team:Presentation
Presentation Team for Dashboard, Input Controls, and Canvas
loe:small
Small Level of Effort
v8.0.0
release_note:skip
Skip the PR/issue when compiling release notes
v7.2.0
v7.3.0
labels
May 29, 2019
Pinging @elastic/kibana-canvas |
w33ble
added
the
impact:critical
This issue should be addressed immediately due to a critical level of impact on the product.
label
May 29, 2019
cqliu1
approved these changes
May 29, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 Kibana was crashing when passing null
to any unnamed arguments. Confirmed that those elements no longer crash the app.
w33ble
added a commit
to w33ble/kibana
that referenced
this pull request
May 29, 2019
typeof null === 'object', so add an explicit check for null
w33ble
added a commit
to w33ble/kibana
that referenced
this pull request
May 29, 2019
typeof null === 'object', so add an explicit check for null
w33ble
added a commit
that referenced
this pull request
May 29, 2019
w33ble
added a commit
that referenced
this pull request
May 29, 2019
💚 Build Succeeded |
dgieselaar
pushed a commit
to dgieselaar/kibana
that referenced
this pull request
May 30, 2019
typeof null === 'object', so add an explicit check for null
jkakavas
pushed a commit
to jkakavas/kibana
that referenced
this pull request
May 30, 2019
typeof null === 'object', so add an explicit check for null
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Fixes for quality problems that affect the customer experience
impact:critical
This issue should be addressed immediately due to a critical level of impact on the product.
loe:small
Small Level of Effort
release_note:skip
Skip the PR/issue when compiling release notes
review
Team:Presentation
Presentation Team for Dashboard, Input Controls, and Canvas
v7.2.0
v7.3.0
v8.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes filterGroup parsing code. If you use a
null
, it'll crash Kibana.typeof null === 'object'
, so this PR adds an explicit check for null.Previous to this PR, this expression would crash Kibana:
Props to @cqliu1 for finding this bug.