Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] [Core] Move Saved objects files to core (#38771) #39158

Merged
merged 2 commits into from
Jun 19, 2019

Conversation

rudolf
Copy link
Contributor

@rudolf rudolf commented Jun 18, 2019

Backports the following commits to 7.x:

@elasticmachine
Copy link
Contributor

💔 Build Failed

* Move src/legacy/server/saved_objects -> src/core/server/saved_objects

* Fix SavedObject import references after moving files to core

* First pass at SavedObjects api docs

* Expose and import all saved object types through core/server

* Don't expose SavedObjectsManagement from core and fix imports

* Improve typings for SavedObject error helpers

* Fix type errors after master merge

* Fix SavedObjectErrorHelpers tests
@rudolf rudolf force-pushed the backport/7.x/pr-38771 branch from c99453c to 0f456f5 Compare June 18, 2019 13:28
@elasticmachine
Copy link
Contributor

💔 Build Failed

@rudolf
Copy link
Contributor Author

rudolf commented Jun 18, 2019

retest

@elasticmachine
Copy link
Contributor

💔 Build Failed

@rudolf
Copy link
Contributor Author

rudolf commented Jun 18, 2019

retest

1 similar comment
@rudolf
Copy link
Contributor Author

rudolf commented Jun 19, 2019

retest

@elasticmachine
Copy link
Contributor

💔 Build Failed

@legrego
Copy link
Member

legrego commented Jun 19, 2019

retest

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@rudolf rudolf merged commit 986b70c into elastic:7.x Jun 19, 2019
@rudolf
Copy link
Contributor Author

rudolf commented Jun 19, 2019

💚 Build Succeeded

@legrego you seem to have the magic touch! 😮

@rudolf rudolf deleted the backport/7.x/pr-38771 branch June 19, 2019 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants