[TSVB] Shim new platform #39169

gospodarsky · 2019-06-18T13:45:14Z

Related to #38615

Summary

1. Identify all public contracts exposed by the existing service (likely not required for most vis type plugins), and create or update the new plugin to re-export the public contracts. This should be a non-breaking change. Plugin should:

Be a directory inside of src/legacy/core_plugins

Have a new platform-style plugin definition in typescript, with a setup method returning the public contract (see data plugin as an example). This needs to be exported from the top-level /server and/or /public directory, e.g. export foo = new Plugin.setup()

Be broken into logical "services", each with a service definition class (see data plugin as an example)

Have all static exports done from the top level plugin definition

Register the visualization via the "visualizations" plugin's types service.

elasticmachine · 2019-06-18T14:55:26Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

gospodarsky · 2019-06-21T13:21:34Z

retest

gospodarsky · 2019-06-21T13:24:25Z

@lukeelmers Please, take a look at the changes. I can't be sure that the changes meet your expectations.

elasticmachine · 2019-06-21T14:22:19Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2019-06-21T16:22:30Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

lukeelmers

Thanks for getting this started! Added some initial notes, though I'd also like to get feedback from @lizozom or @streamich too.

src/legacy/core_plugins/metrics/index.ts

src/legacy/core_plugins/metrics/public/np/index.ts

src/legacy/core_plugins/metrics/public/interpreter/index.ts

src/legacy/core_plugins/metrics/index.ts

src/legacy/core_plugins/metrics/public/np/plugin.ts

src/legacy/core_plugins/metrics/server/np/plugin.ts

src/legacy/core_plugins/metrics/index.ts

src/legacy/core_plugins/metrics/public/kbn_vis_types/index.js

src/legacy/core_plugins/metrics/public/np/plugin.ts

elasticmachine · 2019-06-24T11:13:33Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

lukeelmers

This looks great! Thanks for your patience during all of this back and forth while we sorted out these first PRs. I just added one minor comment.

My only other feedback would be similar to what I commented on #40032 -- I think we should get rid of setup.ts to avoid confusion and move that shim code directly into legacy.ts (moving forward the plan is to have legacy.ts be the central place for any shim code)

Aside from this, I think we're all done here 😄

src/legacy/core_plugins/metrics/public/plugin.ts

…platform

elasticmachine · 2019-07-15T10:20:26Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

…platform

elasticmachine · 2019-07-16T09:29:45Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2019-08-01T10:39:37Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

elasticmachine · 2019-08-02T13:35:36Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

elasticmachine · 2019-08-02T17:32:55Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

…new-platform

elasticmachine · 2019-08-03T12:49:22Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

lukeelmers · 2019-08-05T03:36:20Z

src/legacy/core_plugins/metrics/index.ts

@@ -18,34 +18,39 @@
 */

 import { resolve } from 'path';
+import { Legacy } from 'kibana';
+import { PluginInitializerContext } from 'src/core/server';
+import { CoreSetup } from 'src/core/server';


nit: could combine the above two imports

lukeelmers · 2019-08-05T03:38:58Z

src/legacy/core_plugins/metrics/public/metrics_fn.ts

-    const Private = $injector.get('Private');
-    const metricsRequestHandler = Private(MetricsRequestHandlerProvider).handler;
-
+  async fn(context: Context, args: Arguments) {


nit: context, arguments types don't need to be here

@ts-ignore

* Shim server side to new platform * Shim public to new platfrom * Break by services * Add dependencies to the TSVB plugin * Change folder structure for the shim * Pass services as a second argument of setup() and small fixes * Add start() to the Plugin * Get rid of the Private * Pass the core to setup() * Get rid of NP folder * Set config to timezoneProvider() * Take an external dependency from EditorController * Take an extra dependency out from Request Handler * Rename metricsPlugin to Plugin * Fix reviews * Add types to .setup() * Change types of TSVB * Divide the plugin, its setup config and and entry point * Get rid of @ts-ignore * Add a server type to the CustomCoreSetup interface * Revert kbn_vis_type settings * Restructure public assets * Move setup.js inner to the legacy.ts * clean up * fix PR commnets

…-or-edit-existing-rollup-job * 'master' of github.com:elastic/kibana: (67 commits) [TSVB] Shim new platform (elastic#39169) [Metric Vis] Shim new platform (elastic#42240) [Tag Cloud] Shim new platform (elastic#42348) Disable flaky request lib tests. Add es_ui_shared plugin to CODEOWNERS. Add disk space percentage to node listing (elastic#42145) [SIEM] Add chart interactions - update date picker after brush selection on charts (elastic#42440) Document HTTP service (elastic#42331) [Reporting] Sanitize 409 error log message (elastic#42495) [docs][skip ci] Maps read only access (elastic#35561) [x-pack/ftr] refactor types to be more accurate/consistent wit… (elastic#42407) [DOCS] Updates images and content in Dashboard docs (elastic#42500) Allow sorting on multiple columns in Discover (elastic#41918) [Infra UI][Logs UI] Fix autocomplete to use proper derived index pattern (elastic#42287) [ftr/cheerio] improve cheerio types to include test subject me… (elastic#42534) Upgraded EUI 13.0.0 -> 13.1.1 (elastic#42298) Increase max-old-space-size for builds (elastic#42218) [Infra UI] Add cloud metrics and cloud/host info to metadata endpoint (elastic#41836) [Logs UI][a11y] Announce name of column on remove column button (elastic#41695) Inspector 👉 New Platform (elastic#42164) Make alerting properly space aware (elastic#42081) ...

…s_autocomplete * 'master' of github.com:elastic/kibana: (189 commits) [TSVB] Shim new platform (elastic#39169) [Metric Vis] Shim new platform (elastic#42240) [Tag Cloud] Shim new platform (elastic#42348) Disable flaky request lib tests. Add es_ui_shared plugin to CODEOWNERS. Add disk space percentage to node listing (elastic#42145) [SIEM] Add chart interactions - update date picker after brush selection on charts (elastic#42440) Document HTTP service (elastic#42331) [Reporting] Sanitize 409 error log message (elastic#42495) [docs][skip ci] Maps read only access (elastic#35561) [x-pack/ftr] refactor types to be more accurate/consistent wit… (elastic#42407) [DOCS] Updates images and content in Dashboard docs (elastic#42500) Allow sorting on multiple columns in Discover (elastic#41918) [Infra UI][Logs UI] Fix autocomplete to use proper derived index pattern (elastic#42287) [ftr/cheerio] improve cheerio types to include test subject me… (elastic#42534) Upgraded EUI 13.0.0 -> 13.1.1 (elastic#42298) Increase max-old-space-size for builds (elastic#42218) [Infra UI] Add cloud metrics and cloud/host info to metadata endpoint (elastic#41836) [Logs UI][a11y] Announce name of column on remove column button (elastic#41695) Inspector 👉 New Platform (elastic#42164) Make alerting properly space aware (elastic#42081) ...

@ts-ignore

* Shim server side to new platform * Shim public to new platfrom * Break by services * Add dependencies to the TSVB plugin * Change folder structure for the shim * Pass services as a second argument of setup() and small fixes * Add start() to the Plugin * Get rid of the Private * Pass the core to setup() * Get rid of NP folder * Set config to timezoneProvider() * Take an external dependency from EditorController * Take an extra dependency out from Request Handler * Rename metricsPlugin to Plugin * Fix reviews * Add types to .setup() * Change types of TSVB * Divide the plugin, its setup config and and entry point * Get rid of @ts-ignore * Add a server type to the CustomCoreSetup interface * Revert kbn_vis_type settings * Restructure public assets * Move setup.js inner to the legacy.ts * clean up * fix PR commnets

Shim server side to new platform

001dc1a

gospodarsky added the Feature:TSVB TSVB (Time Series Visual Builder) label Jun 18, 2019

gospodarsky requested a review from a team June 18, 2019 13:45

gospodarsky self-assigned this Jun 18, 2019

gospodarsky added WIP Work in progress release_note:enhancement labels Jun 18, 2019

gospodarsky requested review from lukeelmers, lizozom, yakhinvadim and streamich and removed request for yakhinvadim June 18, 2019 14:53

Artyom Gospodarsky added 3 commits June 20, 2019 14:14

Merge branch 'master' into metrics-shim-new-platform

d4c049c

Shim public to new platfrom

ae523fb

Break by services

1aeb0be

gospodarsky removed the WIP Work in progress label Jun 21, 2019

gospodarsky changed the title ~~[WIP] [TSVB] Shim new platform~~ [TSVB] Shim new platform Jun 21, 2019

lukeelmers requested changes Jun 21, 2019

View reviewed changes

ppisljar reviewed Jun 24, 2019

View reviewed changes

src/legacy/core_plugins/metrics/public/kbn_vis_types/index.js Outdated Show resolved Hide resolved

ppisljar reviewed Jun 24, 2019

View reviewed changes

src/legacy/core_plugins/metrics/public/np/plugin.ts Outdated Show resolved Hide resolved

gospodarsky requested a review from alexwizp June 24, 2019 08:04

Artyom Gospodarsky added 3 commits June 24, 2019 11:14

Merge branch 'master' into metrics-shim-new-platform

c72cebd

Add dependencies to the TSVB plugin

60db353

Change folder structure for the shim

9444061

Pass services as a second argument of setup() and small fixes

2a7174b

lukeelmers reviewed Jul 13, 2019

View reviewed changes

src/legacy/core_plugins/metrics/public/plugin.ts Outdated Show resolved Hide resolved

Artyom Gospodarsky added 2 commits July 15, 2019 11:30

Merge remote-tracking branch 'upstream/master' into metrics-shim-new-…

f1ed49a

…platform

Move setup.js inner to the legacy.ts

5eee987

gospodarsky requested a review from lukeelmers July 15, 2019 10:09

Merge remote-tracking branch 'upstream/master' into metrics-shim-new-…

468ada5

…platform

lukeelmers added Feature:New Platform Feature:NP Migration and removed Feature:New Platform labels Jul 24, 2019

Merge branch 'master' into metrics-shim-new-platform

6b95d14

alexwizp self-assigned this Aug 1, 2019

clean up

f5143e2

alexwizp approved these changes Aug 1, 2019

View reviewed changes

fix PR commnets

ae36579

Merge branch 'master' of github.com:elastic/kibana into metrics-shim-…

5d07730

…new-platform

lukeelmers approved these changes Aug 5, 2019

View reviewed changes

alexwizp merged commit 8d00d26 into elastic:master Aug 5, 2019

alexwizp mentioned this pull request Aug 5, 2019

[7.x] [TSVB] Shim new platform (#39169) #42579

Merged

lukeelmers mentioned this pull request Aug 5, 2019

App Architecture roadmap for New Platform migration #31968

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[TSVB] Shim new platform #39169

[TSVB] Shim new platform #39169

gospodarsky commented Jun 18, 2019 •

edited

Loading

elasticmachine commented Jun 18, 2019

gospodarsky commented Jun 21, 2019

gospodarsky commented Jun 21, 2019

elasticmachine commented Jun 21, 2019

elasticmachine commented Jun 21, 2019

lukeelmers left a comment

elasticmachine commented Jun 24, 2019

lukeelmers left a comment

elasticmachine commented Jul 15, 2019

elasticmachine commented Jul 16, 2019

elasticmachine commented Aug 1, 2019

elasticmachine commented Aug 2, 2019

elasticmachine commented Aug 2, 2019

elasticmachine commented Aug 3, 2019

lukeelmers Aug 5, 2019

lukeelmers Aug 5, 2019

[TSVB] Shim new platform #39169

[TSVB] Shim new platform #39169

Conversation

gospodarsky commented Jun 18, 2019 • edited Loading

Summary

elasticmachine commented Jun 18, 2019

💔 Build Failed

gospodarsky commented Jun 21, 2019

gospodarsky commented Jun 21, 2019

elasticmachine commented Jun 21, 2019

💔 Build Failed

elasticmachine commented Jun 21, 2019

💔 Build Failed

lukeelmers left a comment

Choose a reason for hiding this comment

elasticmachine commented Jun 24, 2019

💔 Build Failed

lukeelmers left a comment

Choose a reason for hiding this comment

elasticmachine commented Jul 15, 2019

💚 Build Succeeded

elasticmachine commented Jul 16, 2019

💔 Build Failed

elasticmachine commented Aug 1, 2019

💚 Build Succeeded

elasticmachine commented Aug 2, 2019

💚 Build Succeeded

elasticmachine commented Aug 2, 2019

💚 Build Succeeded

elasticmachine commented Aug 3, 2019

💚 Build Succeeded

lukeelmers Aug 5, 2019

Choose a reason for hiding this comment

lukeelmers Aug 5, 2019

Choose a reason for hiding this comment

gospodarsky commented Jun 18, 2019 •

edited

Loading