Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade prop-types to an MIT-licensed version #39526

Merged
merged 1 commit into from
Jun 25, 2019

Conversation

peterschretlen
Copy link
Contributor

Summary

Update the version of prop-types we use. The version of prop-types@15.5.8 used in Kibana has a BSD-3 + PATENTS license. The clauses in the patents file can raise concerns with organizations and using the MIT licensed version 15.6.0 or later is preferred.

@peterschretlen peterschretlen added chore release_note:skip Skip the PR/issue when compiling release notes labels Jun 24, 2019
@elasticmachine
Copy link
Contributor

💔 Build Failed

@peterschretlen
Copy link
Contributor Author

peterschretlen commented Jun 24, 2019

retest.
CI failure looked like it was due to offline node

java.io.IOException: Cannot retrieve the node's workspace for hudson.matrix.MatrixProject@3eae0d80[elastic+kibana+pull-request]. Most probably the node is offline

trying again...

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@peterschretlen
Copy link
Contributor Author

Manually reviewed the changes between 15.5.8 and 15.6.0, no concerns:

v15.6.0

Compare Source

v15.5.10

Compare Source

  • Fix a false positive warning when using a production UMD build of a third-party library with a DEV version of React. (@​gaearon in #​50)

v15.5.9

Compare Source

  • Add loose-envify Browserify transform for users who don't envify globally. (@​mridgway in #​45)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore release_note:skip Skip the PR/issue when compiling release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants