-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgrade prop-types to an MIT-licensed version #39526
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterschretlen
added
chore
release_note:skip
Skip the PR/issue when compiling release notes
labels
Jun 24, 2019
streamich
approved these changes
Jun 24, 2019
💔 Build Failed |
retest.
trying again... |
💚 Build Succeeded |
Manually reviewed the changes between
|
peterschretlen
pushed a commit
to peterschretlen/kibana
that referenced
this pull request
Jun 25, 2019
peterschretlen
pushed a commit
to peterschretlen/kibana
that referenced
this pull request
Jun 25, 2019
peterschretlen
pushed a commit
that referenced
this pull request
Jun 26, 2019
peterschretlen
pushed a commit
that referenced
this pull request
Jun 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Update the version of
prop-types
we use. The version ofprop-types@15.5.8
used in Kibana has a BSD-3 + PATENTS license. The clauses in the patents file can raise concerns with organizations and using the MIT licensed version15.6.0
or later is preferred.