Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] Mocks for CoreStart, CoreSetup and PluginInitializerContext (#39351) #39894

Merged
merged 1 commit into from
Jul 1, 2019

Conversation

rudolf
Copy link
Contributor

@rudolf rudolf commented Jun 28, 2019

Backports the following commits to 7.x:

@elasticmachine
Copy link
Contributor

💔 Build Failed

…39351)

* Mocks for CoreStart, CoreSetup and PluginInitializerContext

* Public CoreStart, CoreSetup mocks

* Update api signature/docs

* Convert embaddable_api tests to new core mocks

* CR Feedback

* Introduce ui_new_platform.test.mocks and refactor embedabble tests

* Hack to get TS warnings for Core mocks

* Core mocks types cleanup & hack to get TS warnings for Server Core mocks

* Use __mocks__ new_platform

* Remove accidently commited auto-mock

* Introduce MockedKeys type for Core mocks

* Better typing/docs for UiSettings

* Revert "Use __mocks__ new_platform"

This reverts commit 2d666fa.

* Add missing mock to test

* Cleanup UiSettings types
@rudolf rudolf force-pushed the backport/7.x/pr-39351 branch from 854ab0e to 79c2a4b Compare July 1, 2019 14:12
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@rudolf rudolf merged commit 0a469d2 into elastic:7.x Jul 1, 2019
@rudolf rudolf deleted the backport/7.x/pr-39351 branch July 1, 2019 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants