Fake request interface compatible with Kibana Request #40363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mshustov
added
Team:Core
|
Pinging @elastic/kibana-platform |
mshustov
commented
Jul 4, 2019
| @@ -4,7 +4,7 @@ | |||
|
|
|||
| ## ElasticsearchErrorHelpers class | |||
|
|
|||
| Helpers provided to simplify future migration away from Boom as internal Error. | |||
| Helpers for working with errors returned from the Elasticsearch service.Since the internal data of errors are subject to change, consumers of the Elasticsearch service should always use these helpers to classify errors instead of checking error internals such as `body.error.header[WWW-Authenticate]` | |||
There was a problem hiding this comment.
That's not related to changes, but docs are generated only when api changed and any updates in comments/docs are ignored.
💚 Build Succeeded |
rudolf
approved these changes
Jul 5, 2019
mshustov
added a commit
to mshustov/kibana
that referenced
this pull request
Jul 5, 2019
* make FakeRequest compatible with http request * FakeRequest compatible with Http Request
mshustov
added a commit
that referenced
this pull request
Jul 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Close: #40185
To use common type, otherwise it's problematic to pass, merge them
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.[ ] This was checked for cross-browser compatibility, including a check against IE11[ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support[ ] Documentation was added for features that require explanation or tutorials[ ] Unit or functional tests were updated or added to match the most common scenarios[ ] This was checked for keyboard-only and screenreader accessibilityFor maintainers