Use embeddable v2 - fix regression of #39126 #41221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexwizp
added
release_note:skip
|
Pinging @elastic/kibana-app-arch |
|
retest |
src/legacy/core_plugins/kibana/public/visualize/embeddable/visualize_embeddable_factory.tsx
Show resolved
Hide resolved
|
retest |
💔 Build Failed |
stacey-gammon
approved these changes
Jul 16, 2019
💚 Build Succeeded |
lukeelmers
approved these changes
Jul 17, 2019
There was a problem hiding this comment.
I like this approach to dealing with the async registry issue because:
- We don't have to wait on the injector before loading up our shimmed plugins
- It doesn't require any hackery within the plugins themselves
- We know the registry implementation will be changing in the near term anyway.
Let's just get a final review from @streamich before merging, otherwise this LGTM!
💚 Build Succeeded |
alexwizp
added a commit
to alexwizp/kibana
that referenced
this pull request
Jul 18, 2019
* Use embeddable v2 - fix regression of elastic#39126 * fix PR comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix regression of #39126
Constructors cannot be async, but static methods can. It’s pretty easy to have a static creation method, making the type its own factory
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.For maintainers