-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Uptime] Handle mode: all
in uptime snapshot calculation
#41335
Conversation
Pinging @elastic/uptime |
Patching this function in elastic#41210 fixed performance but was missing this filter clause. We depend on only processing summary info. This fixes errors around missing destructured data where we expect summary fields to be present.
d90596e
to
6b638dd
Compare
💔 Build Failed |
💔 Build Failed |
💔 Build Failed |
💔 Build Failed |
💚 Build Succeeded |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally, seems to work fine. LGTM, WFG
|
||
const fixturesDir = join(__dirname, 'fixtures'); | ||
|
||
export const expectFixtureEql = (data: any, fixtureName: string) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! This is along the lines of the solution I was planning to use to address this.
FYI I created merge conflicts for your branch by merging updates to the README. Took the liberty of merging the changes. |
💔 Build Failed |
jenkins, retest this please |
💚 Build Succeeded |
…1335) Patching this function in elastic#41210 fixed performance but was missing this filter clause. We depend on only processing summary info. This fixes errors around missing destructured data where we expect summary fields to be present.
…1335) Patching this function in elastic#41210 fixed performance but was missing this filter clause. We depend on only processing summary info. This fixes errors around missing destructured data where we expect summary fields to be present.
) (#41424) * [Uptime] Handle `mode: all` in uptime snapshot calculation (#41335) Patching this function in #41210 fixed performance but was missing this filter clause. We depend on only processing summary info. This fixes errors around missing destructured data where we expect summary fields to be present. * Update snapshot to use heartbeat7.0.0 index for backport
) (#41423) * [Uptime] Handle `mode: all` in uptime snapshot calculation (#41335) Patching this function in #41210 fixed performance but was missing this filter clause. We depend on only processing summary info. This fixes errors around missing destructured data where we expect summary fields to be present. * Update snapshot to use heartbeat7.0.0 index for backport
Patching this function in #41210 fixed performance but was missing this filter clause. We depend on only processing summary info. This fixes errors around missing destructured data where we expect summary fields to be present.
This needs additional tests before merging.Summary
Summarize your PR. If it involves visual changes include a screenshot or gif.
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.For maintainers