[InfraUI] [LogsUI] Accessibility fixes #41883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kerry350
added
review
release_note:fix
Feature:Metrics UI
|
Pinging @elastic/infra-logs-ui |
|
Ah, some of the functional tests were relying on |
💔 Build Failed |
💚 Build Succeeded |
…e source configuration panel" This reverts commit 5075777.
💚 Build Succeeded |
💔 Build Failed |
|
retest |
💚 Build Succeeded |
Kerry350
added a commit
to Kerry350/kibana
that referenced
this pull request
Aug 2, 2019
* Fixes elastic#40411 - Add aria-label to search input * Fixes elastic#40425 - Align gear icon aria-labels * Fixes elastic#40419 - Make use of EuiDescribedFormGroup in the source configuration panel * Add data-test-subj attribute back for functional test * Revert "Fixes elastic#40419 - Make use of EuiDescribedFormGroup in the source configuration panel" This reverts commit 5075777.
Kerry350
added a commit
that referenced
this pull request
Aug 5, 2019
* Fixes #40411 - Add aria-label to search input * Fixes #40425 - Align gear icon aria-labels * Fixes #40419 - Make use of EuiDescribedFormGroup in the source configuration panel * Add data-test-subj attribute back for functional test * Revert "Fixes #40419 - Make use of EuiDescribedFormGroup in the source configuration panel" This reverts commit 5075777.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses
32 accessibility issues. The individual commits contain the relevant issue number, and should be easy to review in isolation.The only issue that introduces any significant change is #40419. For this I opted to use EUI'sEuiDescribedFormGroupcomponent. This component adds the relevantrole,idandaria-labelledbyattributes. However, it does introduce a visual alignment change. To avoid a lot of whitespace to the left I've made use of thedescriptionprop.Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.