Update heading hierarchy for instructions #41970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
myasonik
added
the
Team:Visualizations
|
Pinging @elastic/kibana-app |
💔 Build Failed |
myasonik
force-pushed
the
fix/instructions-heading-hierarchy
branch
from
a39f7cc to
ca3d935
Compare
💚 Build Succeeded |
…ons-heading-hierarchy
💚 Build Succeeded |
myasonik
pushed a commit
to myasonik/kibana
that referenced
this pull request
Jul 29, 2019
myasonik
pushed a commit
that referenced
this pull request
Jul 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Updates the heading hierarchy: the page had no
h1, but severalh2s at different levels so I promoted one.This PR was going to be bigger but the other a11y issues turned out to be in EUI.
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.- [ ] This was checked for cross-browser compatibility, including a check against IE11- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support- [ ] Documentation was added for features that require explanation or tutorialsFor maintainers