Export public http interfaces #42001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mshustov
added
review
chore
Team:Core
|
Pinging @elastic/kibana-platform |
💔 Build Failed |
|
retest |
💔 Build Failed |
eliperelman
approved these changes
Jul 26, 2019
|
Or I guess the typo is in the PR, so we are good lol. |
💔 Build Failed |
mshustov
added a commit
to mshustov/kibana
that referenced
this pull request
Jul 26, 2019
* re-export http types * update docs
mshustov
added a commit
that referenced
this pull request
Jul 27, 2019
jfsiii
pushed a commit
that referenced
this pull request
Aug 1, 2019
* WIP. Update home/list screen. Pulling in ideas from https://github.com/jfsiii/kibana/pull/2 * WIP. Home screen w/ plenty o'hacks but includes icons & better layout. * Use 4 column List view layout as in Figma. Left Title. Other 3 are cards * Use NP breadcrumbs. Add context w/ core & other deps. Add routes as dep. * PLUGIN_ID -> PLUGIN.ID. Consistent w/most other plugins. * Move some repeated strings under PLUGIN namespace * Less noisy (more idiomatic?) approach to contexts & hooks * Add useBreadcrumbs hook. Views call useBreadcrumbs(arrayOfBreadcrumbs). * Detail page uses EuiPage & EuiPageBody like the List page does. * Add Hero image. Vertically center copy and push image to bottom. Line-height, color and some other items are not to spec yet. Using inline styles while we're iterating. Will extract to CSS / Sass soon. * Factor <HeroCopy> & <HeroImage> out of <Header> * Remove header background. Add grey bottom border. * Fix i18n errors. Prior bad merge of 81153c2 * Use PLUGIN.TITLE now that it has translated string * Use snake case for image name * Remove comments disabling import warnings. #42001 has landed * Pass core.http.fetch into public/data * Replace basePath.prepend in routes w/plain string. * Move link generators into to new useLinks hook. 6e7e60d broke the paths because I forgot what `basePath` actually does. This moves the functions into a hook. Usage is nearly identical in views. Also adds a path function for assets. I didn't realize those were broken because I was running with `--no-base-path` * Destructure to* functions from useLinks return value. I wrote them so they could be used like the previous `import { linkToSomething } from './routes'` then forgot to use them that way. * Rename hooks/x files to hooks/use_x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.