Pass uiSettings to all data plugin services #42159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
June 19, 2019 15:40
…op-nav/new-directive
…-nav/new-directive
…n-top-nav/new-directive
…op-nav/new-directive
…op-nav/new-directive
…op-nav/new-directive
…orm/kbn-top-nav/new-directive
Support search bar with no filter bar (TS)
…op-nav/new-directive
…op-nav/new-directive
…watched correctly.
added 2 commits
August 6, 2019 11:38
…plugin/data-plugin-deps
💔 Build Failed |
💔 Build Failed |
💔 Build Failed |
💚 Build Succeeded |
lukeelmers
reviewed
Aug 6, 2019
src/legacy/core_plugins/data/public/index_patterns/index_patterns_service.ts
Show resolved
Hide resolved
src/legacy/core_plugins/data/public/search/search_bar/components/search_bar.tsx
Show resolved
Hide resolved
src/legacy/core_plugins/kibana/public/visualize/editor/editor.html
Outdated
Show resolved
Hide resolved
src/legacy/core_plugins/metrics/public/contexts/query_input_bar_context.ts
Show resolved
Hide resolved
alexwizp
approved these changes
Aug 7, 2019
added 3 commits
August 7, 2019 12:12
…plugin/data-plugin-deps
…plugin/data-plugin-deps
💔 Build Failed |
💚 Build Succeeded |
lukeelmers
approved these changes
Aug 8, 2019
There was a problem hiding this comment.
This all LGTM, but to be honest I don't fully understand the angular code that has been added to the legacy module shim (probably just me not being an angular expert).
AFAICT it is basically doing some magic to add the uiSettings to $scope? Is it serving any other purpose?
Anyway, I'm cool with moving forward with this, but just wanted to add that caveat. @alexwizp probably also knows more about the angular stuff than me, so if he's comfortable with it, I'm on board.
|
Yes @lukeelmers, this is done to inject settings into the filter bar directive when it's being used directly and not through top nav. It's the same type of helper directive I used for too nav. |
…plugin/data-plugin-deps
💚 Build Succeeded |
This was referenced Aug 11, 2019
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Aug 12, 2019
…p-metrics-selectall * 'master' of github.com:elastic/kibana: (22 commits) [Code]: downgrade the log level of error message from subprocess (elastic#42925) [Code] Cancel clone/update job in the middle if disk space over the watermark (elastic#42890) Add Kibana App specific URL to the help menu (elastic#34739) (elastic#42580) [Maps] refactor createShapeFilterWithMeta to support more than just polygons (elastic#43042) Skip flaky es_ui_shared/request tests. Pass uiSettings to all data plugin services (elastic#42159) [SIEM] Upgrades react-redux and utilize React.memo for performance gains (elastic#43029) [skip-ci][Maps] add maki icon sheet to docs (elastic#43063) Adding "style-src 'unsafe-inline' 'self'" to default CSP rules (elastic#41305) Update dependency commander to v3 (elastic#43041) Update dependency @percy/agent to ^0.10.0 (elastic#40517) [Maps] only show top hits checkbox if index has date fields (elastic#43056) run chained_controls on Firefox to catch regression (elastic#43044) fixing issue with dashboard csv download (elastic#42964) Expose task manager as plugin instead of server argument (elastic#42966) Expose createRouter from HttpService, prepare handlers for context introduction (elastic#42686) [Code] disk watermark supports percentage and absolute modes (elastic#42987) [apps/dashboard] skip part of filtering tests on FF (elastic#43047) [ML] Kibana management jobs list (elastic#42570) [ML] Fix check for watcher being enabled (elastic#43025) ...
|
Looks like this PR missed one usage of the filter bar in the "View surrounding documents" view: kibana/src/legacy/core_plugins/kibana/public/context/app.html Lines 1 to 6 in 974b5fd |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Shape data plugin into standard shape + pass uiSettings from top level to all services
Dev Docs
Introduction of
QueryBarWrapperfor TSVBMost TSVB panels and componenbts use
QueryInputBar, which now requires some core dependencies. To make it easier to pass those down fromeditor, I addedQueryBarWrapper, which at the moment, provides:Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.For maintainers