[Core] Make type option required for SavedObjects.find #42236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rudolf
added
Feature:New Platform
Team:Core
|
Pinging @elastic/kibana-platform |
rudolf
added
the
release_note:skip
rudolf
force-pushed
the
saved-objects-find-options
branch
from
098be95 to
10fd3e6
Compare
rudolf
force-pushed
the
saved-objects-find-options
branch
2 times, most recently
from
854ec04 to
f82aa42
Compare
rudolf
force-pushed
the
saved-objects-find-options
branch
from
f82aa42 to
0313b50
Compare
💚 Build Succeeded |
rudolf
commented
Aug 7, 2019
| type: noteSavedObjectType, | ||
| ...options, | ||
| }); | ||
| const savedObjects = await savedObjectsClient.find(options); |
There was a problem hiding this comment.
@XavierM making type required in SavedObjectsFindOptions means we either have to include the type in every getAllSavedNote() call, or change the signature of getAllSavedNote()'s options parameter to not be SavedObjectsFindOptions.
kobelb
approved these changes
Aug 7, 2019
joshdover
approved these changes
Aug 9, 2019
💚 Build Succeeded |
|
@elastic/siem Anyone able to review these minor changes I made to the SIEM plugin? |
💚 Build Succeeded |
rudolf
added a commit
to rudolf/kibana
that referenced
this pull request
Aug 12, 2019
* Make type option required for SavedObjects.find * getSortedObjectsForExport test for type or objects
rudolf
added a commit
that referenced
this pull request
Aug 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Make the type option required for
SavedObjectsFindOptionsthe interface used bySavedObjects.find()since not supplying will throw a runtime exception https://github.com/elastic/kibana/blob/master/src/core/server/saved_objects/service/lib/repository.ts#L409.Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.This was checked for cross-browser compatibility, including a check against IE11Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n supportDocumentation was added for features that require explanation or tutorialsUnit or functional tests were updated or added to match the most common scenariosThis was checked for keyboard-only and screenreader accessibilityFor maintainers
This was checked for breaking API changes and was labeled appropriatelyThis includes a feature addition or change that requires a release note and was labeled appropriately