Move SearchBar back to data plugin. #42449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Restored an empty service for Saved Queries to use
lizozom
added
Feature:New Platform
v8.0.0
release_note:skip
27 tasks
💚 Build Succeeded |
Bargs
reviewed
Aug 1, 2019
| @@ -23,7 +23,7 @@ import { EuiFlexGroup, EuiFlexItem } from '@elastic/eui'; | |||
| import { I18nProvider } from '@kbn/i18n/react'; | |||
| import { TopNavMenuData } from './top_nav_menu_data'; | |||
| import { TopNavMenuItem } from './top_nav_menu_item'; | |||
| import { SearchBar, SearchBarProps } from '../search_bar'; | |||
| import { SearchBar, SearchBarProps } from '../../../../core_plugins/data/public'; | |||
There was a problem hiding this comment.
Should we expose the UI component via the search service, or is the best practice to statically import like this now? Asking mainly so I know what to do in our saved query PR.
TinaHeiligers
approved these changes
Aug 1, 2019
|
@lizozom I went ahead and merged since tests passed and it looked good to us. Thanks for submitting this, now we are unblocked :) I tried to backport for you but there were some conflicts that I wasn't sure how best to resolve, so I will leave that to you. |
lizozom
pushed a commit
to lizozom/kibana
that referenced
this pull request
Aug 1, 2019
Restored an empty service for Saved Queries to use
lizozom
pushed a commit
that referenced
this pull request
Aug 2, 2019
|
Pinging @elastic/kibana-app-arch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Reverts some of the changes in #41636
Move SearchBar back to data plugin.
Also restored an empty service for Saved Queries to use.
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.For maintainers