Allowing individual privileges to be excluded from base privileges #42470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kobelb
added
release_note:plugin_api_changes
|
retest |
💔 Build Failed |
💚 Build Succeeded |
…-individual-privilege-from-base
💚 Build Succeeded |
…-individual-privilege-from-base
💔 Build Failed |
|
retest |
legrego
reviewed
Aug 13, 2019
.../security/public/lib/kibana_privilege_calculator/kibana_feature_privilege_calculator.test.ts
Outdated
Show resolved
Hide resolved
| @@ -120,9 +120,9 @@ describe('only global', () => { | |||
| ]); | |||
💚 Build Succeeded |
…culator/kibana_feature_privilege_calculator.test.ts Co-Authored-By: Larry Gregory <lgregorydev@gmail.com>
💚 Build Succeeded |
kobelb
added a commit
to kobelb/kibana
that referenced
this pull request
Aug 13, 2019
…lastic#42470) * Excluding code from base privileges * Allowing individual privileges to be excluded * Only returning a boolean for directlyAssigned... for space feature privileges * We are now called directlyAssignedPrivilegeMorePermissiveThanBase * An even longer and potentially more accurate name * Fixing KibanaPrivilegeCalculator tests * Fixing KibanaAllowedPrivilegesCalculator tests * Adding privilege space table tests * Updating privilegesFactory tests * Removing code's usage * Updating snapshot * Update x-pack/legacy/plugins/security/public/lib/kibana_privilege_calculator/kibana_feature_privilege_calculator.test.ts Co-Authored-By: Larry Gregory <lgregorydev@gmail.com>
kobelb
added a commit
that referenced
this pull request
Aug 13, 2019
…42470) (#43214) * Excluding code from base privileges * Allowing individual privileges to be excluded * Only returning a boolean for directlyAssigned... for space feature privileges * We are now called directlyAssignedPrivilegeMorePermissiveThanBase * An even longer and potentially more accurate name * Fixing KibanaPrivilegeCalculator tests * Fixing KibanaAllowedPrivilegesCalculator tests * Adding privilege space table tests * Updating privilegesFactory tests * Removing code's usage * Updating snapshot * Update x-pack/legacy/plugins/security/public/lib/kibana_privilege_calculator/kibana_feature_privilege_calculator.test.ts Co-Authored-By: Larry Gregory <lgregorydev@gmail.com>
7 tasks
💚 Build Succeeded |
|
👏 nice job Elastic Machine, I knew you could do it! |
😆 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Individual feature's privileges can now be excluded from the base privileges. For example, the following feature excludes the
allfeature privilege from being automatically included in any of the base privileges:Changes to the kibana privileges calculator were required to support this in the UI. We're now returning a
directlyAssignedFeaturePrivilegeMorePermissiveThanBaseproperty on the calculated privileges only for feature privileges for a specific space(s). We aren't calculating this for the global (all spaces) entries, as we only allow either base or feature privileges here, so this isn't currently required.DevDocs
Individual feature's privileges can now be excluded from the base privileges using
excludeFromBasePrivilege