Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated index patterns field methods. #42643

Merged
merged 1 commit into from
Aug 6, 2019

Conversation

lukeelmers
Copy link
Member

@lukeelmers lukeelmers commented Aug 5, 2019

This removes some old getters on index patterns Field which were no longer being used. They were deprecated back in 5.5 and since then have simply been throwing errors if called:

  • Field.indexed
  • Field.analyzed
  • Field.doc_values

This has no affect on any other places in Kibana, since the getters were already throwing errors to begin with, and thus are basically dead code.

@lukeelmers lukeelmers added Feature:Data Views Data Views code and UI - index patterns before 8.0 v8.0.0 Team:AppArch v7.4.0 Feature:NP Migration labels Aug 5, 2019
@lukeelmers lukeelmers requested a review from lizozom August 5, 2019 22:17
@lukeelmers lukeelmers self-assigned this Aug 5, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch

@lukeelmers lukeelmers added the release_note:skip Skip the PR/issue when compiling release notes label Aug 5, 2019
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Copy link
Contributor

@lizozom lizozom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lukeelmers lukeelmers merged commit 6cd3a67 into elastic:master Aug 6, 2019
@lukeelmers lukeelmers deleted the fix/index-patterns-cleanup branch August 6, 2019 19:02
lukeelmers added a commit to lukeelmers/kibana that referenced this pull request Aug 6, 2019
@lukeelmers lukeelmers removed the review label Aug 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Data Views Data Views code and UI - index patterns before 8.0 Feature:NP Migration release_note:skip Skip the PR/issue when compiling release notes v7.4.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants