Update Storybook Dependencies #44519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clintandrewhall
added
review
chore
Team:Operations
|
Pinging @elastic/kibana-canvas |
|
Pinging @elastic/kibana-operations |
This comment has been minimized.
This comment has been minimized.
|
Skipped flaky test #22322 |
💚 Build Succeeded |
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Sep 2, 2019
…-to-np-ready * 'master' of github.com:elastic/kibana: (409 commits) [ML] Data frame analytics: Fix source index checks. (elastic#44479) [Code] try fix this test (elastic#43692) skip flaky suite (elastic#44572) (elastic#42111) (elastic#44286) (elastic#43557) (elastic#42567) skip flaky suite (elastic#44560) skip flaky suite (elastic#44250) disable flaky suite (elastic#41336) [code] Update download URLs for go lsp. (elastic#44581) disable flaky suite (elastic#44575) disable flaky suite (elastic#44576) [Code] add functional test to verify lang server full api symbol/reference counts (elastic#44051) Improve Storybook scripts and load time (elastic#44511) Update Dependencies (elastic#44519) Remove use of injecti18n in Embeddables plugin (elastic#44043) [SIEM] Adds a configuraton option for the default SIEM date time range (elastic#44540) [Uptime]Fix/issue 40584 section headline should be inside panel (elastic#43468) disable flaky suite (elastic#22322) Changes network to use ECS fields (elastic#44392) Fix 'workpad flash' when loading new workpad (elastic#44387) [renovate] bump new PR version labels Update dependency cmd-shim to ^2.1.0 (elastic#44034) ... # Conflicts: # src/legacy/core_plugins/console/public/index.html
clintandrewhall
added a commit
that referenced
this pull request
Sep 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates Storybook in Canvas to 5.1.11. I figured the start of 7.5 would be an opportune time to pull the trigger on this. There are a number of
yarn.lockchanges, but at first glance, they appear benign (e.g.core-jsremains in 3.x.x). I tested this in FF and IE 11.Other eyes on this PR would be helpful. I'm beginning to think I need to create a
package.jsonfor Storybook, or all of this will be unnecessary if/when #43529 is completed. If so, I'll punt on this update.Checklist