Color field format #4594
Color field format #4594
Conversation
|
This is a really nice feature. Can't wait to play with it! Well done. |
|
+1 |
|
I am not sure if I am trying to do something similar. But are you trying to add some highlight or change the color of the table during discovery? i.e. each message type has their own color? That way you can easily identify the type of logs when looking at the table. +1 |
|
LGTM! Needs a merge with master. |
|
@MichaelLiZhou Yep, although this only covers numbers. |
|
Any advice on trying to highlight the entire row of the discovery table? Or in the dashboard tables? I want to try and add some colors to them. |
|
Nothing that I know of to highlight entire rows currently. You can draw attention to specific fields by writing your own field formatters similar to this, https://www.elastic.co/blog/kibana-custom-field-formatters should be able to help. |
|
Found some strange behavior:
|
|
@BigFunger I addressed 1, 2, and 3. I'm more in favor of validation as a separate issue with consistency across the other formatters if desired. Currently the behavior similar to bytes, number, percentages formatters where gibberish formats are accepted. Open to changing it still if you think it's an issue, let me know. |
|
I should be able to delete any of the items. By default, I am unable to delete the top item. |
| var _ = require('lodash'); | ||
| var FieldFormat = Private(require('ui/index_patterns/_field_format/FieldFormat')); | ||
|
|
||
| require('ui/field_format_editor/samples/samples'); |
There was a problem hiding this comment.
This line isn't needed anymore since you've changed the way you're displaying samples.
|
With the exception of the unnecessary require statement, LGTM! |
| @@ -0,0 +1,58 @@ | |||
| define(function (require) { | |||
| return function _StringProvider(Private) { | |||
| var _ = require('lodash'); | |||
|
|
|
Discussed with @panda01 offline, validation was opened as a separate issue. |
|
LGTM! |
Adds a number field formatter that lets you to specify colors within defined ranges. Closes #1726.