[Lens] Cleanup SASS and add linting #46100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@miukimiu I had to create a new branch and cherry pick our commits because the Lens feature branch which we originally branched off of was squashed and merged into master. |
cchaos
added
the
release_note:skip
💚 Build Succeeded |
cchaos
force-pushed
the
lens-cleanup-sass
branch
from
550a8dd to
82bcb0f
Compare
💚 Build Succeeded |
# Conflicts: # x-pack/legacy/plugins/lens/public/index.scss
Sass cleanup for drag and drop comp
cchaos
force-pushed
the
lens-cleanup-sass
branch
from
82bcb0f to
2ea8b78
Compare
💚 Build Succeeded |
|
Thanks @wylieconlon , Can you mark it as approved? |
wylieconlon
approved these changes
Sep 23, 2019
cchaos
added a commit
that referenced
this pull request
Sep 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just SASS cleanup
Moves styles to their correct respective files and renames classes to be inline with their component names. Linting wasn't too bad actually, only a few things. Everything should still be as it was.