Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shim ui/autocomplete_providers into legacy data plugin #46138

Merged
merged 8 commits into from
Sep 24, 2019
Merged

Shim ui/autocomplete_providers into legacy data plugin #46138

merged 8 commits into from
Sep 24, 2019

Conversation

alexwizp
Copy link
Contributor

Fix: #44949

What was done in this PR:

  • Convert index.js -> index.ts
  • Move contents of ui/autocomplete_providers into data plugin (service location TBD, should be discussed with @lizozom), and expose via shim
  • Re-export from ui/autocomplete_providers for backwards compatibility

Summary

Summarize your PR. If it involves visual changes include a screenshot or gif.

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

@alexwizp alexwizp force-pushed the autocomplete_providers branch 3 times, most recently from 0516e3c to 971f657 Compare September 19, 2019 15:40
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@elasticmachine
Copy link
Contributor

💔 Build Failed

@alexwizp alexwizp force-pushed the autocomplete_providers branch from 971f657 to 8e99544 Compare September 20, 2019 11:01
@alexwizp alexwizp force-pushed the autocomplete_providers branch from 8e99544 to b75704d Compare September 20, 2019 11:48
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@alexwizp alexwizp self-assigned this Sep 20, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch

@alexwizp alexwizp marked this pull request as ready for review September 20, 2019 14:00
@alexwizp alexwizp requested review from a team as code owners September 20, 2019 14:00
@alexwizp alexwizp requested a review from a team September 20, 2019 14:00
@alexwizp alexwizp requested review from a team as code owners September 20, 2019 14:00
@alexwizp alexwizp added the release_note:skip Skip the PR/issue when compiling release notes label Sep 20, 2019
weltenwort
weltenwort approved these changes Sep 20, 2019
View reviewed changes
Copy link
Member

@weltenwort weltenwort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from an infra plugin perspective - thank you!

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

lizozom
lizozom suggested changes Sep 23, 2019
View reviewed changes
src/legacy/core_plugins/data/public/query/query_bar/components/query_bar_input.tsx Outdated Show resolved Hide resolved
src/plugins/data/common/autocomplete_provider/index.ts Outdated Show resolved Hide resolved
x-pack/legacy/plugins/uptime/public/components/functional/kuery_bar/index.tsx Show resolved Hide resolved
src/plugins/data/common/autocomplete_provider/index.ts Outdated Show resolved Hide resolved
x-pack/legacy/plugins/kuery_autocomplete/public/plugin.ts Show resolved Hide resolved
x-pack/legacy/plugins/ml/public/components/kql_filter_bar/utils.js Outdated Show resolved Hide resolved
src/plugins/data/common/autocomplete_provider/index.ts Outdated Show resolved Hide resolved
src/plugins/data/public/plugin.ts Outdated Show resolved Hide resolved
@elasticmachine
Copy link
Contributor

💔 Build Failed

sorenlouv
sorenlouv approved these changes Sep 23, 2019
View reviewed changes
Copy link
Member

@sorenlouv sorenlouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

APM changes lgtm

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

peteharverson
peteharverson approved these changes Sep 24, 2019
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested ML edits, and LGTM

lizozom
lizozom approved these changes Sep 24, 2019
View reviewed changes
Copy link
Contributor

@lizozom lizozom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Note: We'll have to revisit autocomplete_providers and remove the npStart import from query_bar_input.

@alexwizp alexwizp merged commit ce23ded into elastic:master Sep 24, 2019
@alexwizp alexwizp mentioned this pull request Sep 24, 2019
Merged
alexwizp added a commit to alexwizp/kibana that referenced this pull request Sep 24, 2019
@alexwizp
Shim ui/autocomplete_providers into legacy data plugin (elastic#46138)
8e9ec7b 
* Shim ui/autocomplete_providers into legacy data plugin

Fix: elastic#44949

* Fix PR commnets

* fix CI

* Add comment
alexwizp added a commit that referenced this pull request Sep 24, 2019
@alexwizp
Shim ui/autocomplete_providers into legacy data plugin (#46138) (#46479)
f497b61 
* Shim ui/autocomplete_providers into legacy data plugin

Fix: #44949

* Fix PR commnets

* fix CI

* Add comment
This was referenced Nov 21, 2019
Closed
Closed
@alexwizp alexwizp deleted the autocomplete_providers branch January 4, 2020 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peteharverson peteharverson peteharverson approved these changes

@lizozom lizozom lizozom approved these changes

@weltenwort weltenwort weltenwort approved these changes

@sorenlouv sorenlouv sorenlouv approved these changes

@gospodarsky gospodarsky Awaiting requested review from gospodarsky

@lukeelmers lukeelmers Awaiting requested review from lukeelmers

@ppisljar ppisljar Awaiting requested review from ppisljar

Assignees

@alexwizp alexwizp

Labels
Feature:Filters Feature:NP Migration release_note:skip Skip the PR/issue when compiling release notes v7.5.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Shim ui/autocomplete_providers into legacy data plugin
6 participants
@alexwizp @elasticmachine @sorenlouv @weltenwort @lizozom @peteharverson