Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add compatibility layer for ApplicationService in legacy platform #46659

Merged
merged 2 commits into from
Oct 3, 2019
Merged

Add compatibility layer for ApplicationService in legacy platform #46659

merged 2 commits into from
Oct 3, 2019

Conversation

joshdover
Copy link
Contributor

@joshdover joshdover commented Sep 25, 2019 •
edited
Loading

Summary

Closes #46481

This adds a compatibility function for "registering an app" in the Legacy Platform which simply just renders the app using ui/chrome.

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

@joshdover
Copy link
Contributor Author

retest

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@joshdover joshdover added Feature:New Platform Feature:NP Migration release_note:skip Skip the PR/issue when compiling release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v7.5.0 labels Sep 26, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-platform

@joshdover joshdover marked this pull request as ready for review September 26, 2019 19:04
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@joshdover joshdover force-pushed the np/app-legacy-compat branch from d521973 to 47e9126 Compare October 2, 2019 21:58
@joshdover
Copy link
Contributor Author

Unit and functional tests added.

@elasticmachine
Copy link
Contributor

💔 Build Failed

@joshdover
Copy link
Contributor Author

retest

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@joshdover joshdover merged commit ef8b2a3 into elastic:master Oct 3, 2019
@joshdover joshdover deleted the np/app-legacy-compat branch October 3, 2019 16:11
@joshdover joshdover mentioned this pull request Oct 3, 2019
Merged
joshdover added a commit to joshdover/kibana that referenced this pull request Oct 3, 2019
@joshdover
Add compatibility layer for ApplicationService in legacy platf… (elas…
df29ab0 
…tic#46659)
@mshustov mshustov mentioned this pull request Oct 14, 2019
Merged
7 tasks
@rudolf rudolf mentioned this pull request Jan 8, 2020
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mshustov mshustov mshustov approved these changes

Assignees
No one assigned
Labels
Feature:New Platform Feature:NP Migration release_note:skip Skip the PR/issue when compiling release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v7.5.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a legacy compatibility layer for ApplicationService
3 participants
@joshdover @elasticmachine @mshustov