Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] [SIEM] Table Styles & Markup Tweaks (#46300) #47131

Merged

Conversation

MichaelMarcialis
Copy link
Contributor

Backports the following commits to 7.x:

* restore conditional space before AS number

* touchup table widths and text

* adjust datepicker width

* refactor matchMedia; set bp to above mbp rez

* timeline table body refactor, first pass

* TruncatableText: rm “width”, added “truncated”

* cleanup imports

* cleanup styles

* rm size prop

* swap out div? prob need to fix ref

* restore truncation in timeline

* think i have text overflow and tooltips happy now

* light clean up

* single overflow scrolling element

* use polished for hex in rgba needs

* simplify body markup

* events table header poc

* close button fixes

* improve sort indicator position

* drag handle updates

* fix fields browser positioning

* apply aria roles

* fix blown out table width

* localize sorting onClick to header text

* correct key placement

* prevent hover and click for unsortable and add btn

* rm btn for non aggregatable col headers

* change width/height prop names to avoid html attr

* fix loading alignment

* account for action cell width when one action

* clean up trGroup organization

* imports cleanup

* fix types and skeleton rows/cells poc

* new skeleton row comp

* fix column heads not dragging

* supplement row indentation

* move widths out of styled components for perf

* inline dynamic width

* account for inline styles with dnd

* cleanup

* tweak in-page events table styling for consistency

* cleanup

* make compressed for consistency

* cleanup

* update jest tests + change matchMedia to css mq

* fix missing grab cursor in IE11

* fix action td group width in IE11

* fix columns menu positioning in IE11

* fix collapsing notes in timelines table in IE11

* decouple from DroppableWrapper to prevent issues

* update snapshots

* more specific selector

* rm show prop

* add truncate to shouldComponentUpdate

* bulk up `HeaderPanel` unit tests

* correct conditional styles and add some more tests

* improve SkeletonRow unit tests

* change for loop to map

* switch from pure to React.memo

* make SkeletonRow cellCount dynamic

* rm comments

* fix buttons not being draggable for col headers

* fix for safari position sticky + overflow auto bug

* correct type errors

* correct field browser overlap

* missing semicolon
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@MichaelMarcialis MichaelMarcialis merged commit d2cddc9 into elastic:7.x Oct 2, 2019
@MichaelMarcialis MichaelMarcialis deleted the backport/7.x/pr-46300 branch October 2, 2019 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants