[Monitoring] Fix broken scrubbing on monitoring charts #47382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisronline
added
review
Team:Monitoring
|
Pinging @elastic/stack-monitoring (Team:Monitoring) |
💔 Build Failed |
|
@elasticmachine merge upstream |
💚 Build Succeeded |
igoristic
reviewed
Oct 8, 2019
| @@ -152,9 +168,11 @@ export class MonitoringViewBaseController { | |||
| this.onBrush = ({ xaxis }) => { | |||
| removePopstateHandler(); | |||
| const { to, from } = xaxis; | |||
| const timezone = config.get('dateFormat:tz'); | |||
| const offset = getOffsetInMS(timezone); | |||
There was a problem hiding this comment.
More of nitpick, but I think timezone and offset can be calculated just once in the constructor, unless config.get always gets the latest/updated value
igoristic
approved these changes
Oct 8, 2019
chrisronline
added a commit
to chrisronline/kibana
that referenced
this pull request
Oct 8, 2019
* Apply an offset on brush * Fix test
chrisronline
added a commit
to chrisronline/kibana
that referenced
this pull request
Oct 8, 2019
* Apply an offset on brush * Fix test
chrisronline
added a commit
that referenced
this pull request
Oct 8, 2019
chrisronline
added a commit
that referenced
this pull request
Oct 8, 2019
cqliu1
pushed a commit
to cqliu1/kibana
that referenced
this pull request
Oct 9, 2019
elastic#47585) * Apply an offset on brush * Fix test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #47380
This PR applies an offset to the updated
toandfromUTC timestamps received from theonBrushcallback to account for the recently applied offset on the server.While working on this, I realized this bug seems to affect brushing too.