Initial alerting UI and actions list #47843

mikecote · 2019-10-10T14:55:24Z

In this PR, we're adding a new plugin "alertingUI" that will handle the rendering of alerts and actions. The reason for a separate plugin is to still be able to render the UI when alerting plugin is disabled but actions plugin is still enabled.

This PR includes a new top level tabs that will eventually have Actions, Alerts, Activity Log and Notifications as per mock ups. This PR also includes the actions list with delete functionality.

Note: This merges into a feature branch that will later on be merged into master.

Resolves #47754
Resolves #47755

Screenshot:

elasticmachine · 2019-10-10T14:55:26Z

Pinging @elastic/kibana-stack-services (Team:Stack Services)

…kers in the UI the action type column (from id to name)

…rieved from server action types list

bmcconaghy

Some minor things. I will be pulling this down and testing it for a11y and UX soon.

x-pack/legacy/plugins/actions/server/plugin.ts

x-pack/legacy/plugins/alerting_ui/index.ts

x-pack/legacy/plugins/alerting_ui/np_ready/kibana.json

bmcconaghy · 2019-10-18T14:46:32Z

x-pack/legacy/plugins/alerting_ui/np_ready/public/application/constants/index.ts

+ */
+
+export const BASE_PATH = '/management/kibana/alerting';
+export const BASE_ACTION_API_PATH = '../api/action';


We should be building this up with chrome.getBasePath() instead I think.

I removed the prefix ../ in 70e8606 but I think the http service now takes care of the base path handling. It works for me while having the 3 character base path enabled.

x-pack/legacy/plugins/alerting_ui/np_ready/public/application/context/app_context.tsx

x-pack/legacy/plugins/alerting_ui/np_ready/public/application/home.tsx

...ns/alerting_ui/np_ready/public/application/sections/actions_list/components/actions_list.tsx

YulNaumenko

LGTM in general. I have proposal to change plugin name to AlertingUiPlugin, because the current one came up historically.

x-pack/legacy/plugins/alerting_ui/np_ready/public/plugin.ts

…feature/alerting_ui_plugin

...ns/alerting_ui/np_ready/public/application/sections/actions_list/components/actions_list.tsx

pmuellr

Just reviewed to get familiar with what building a UI for Kibana entails, left a few nit comments.

pmuellr · 2019-10-21T13:57:23Z

...ting_ui/np_ready/public/application/sections/actions_list/components/create_menu_popover.tsx

+          selectMessage: i18n.translate(
+            'xpack.alertingUI.sections.actions.emailAction.selectMessageText',
+            {
+              defaultMessage: 'Send an email from your server.',


not sure "from your server" is required here

This file is for the next upcoming PR (#48191) to create / edit actions. We decided instead of cleaning it up that we'll leave it there until the next PR lands. In order to avoid merge conflicts, we'll address this feedback in the next PR cc @YulNaumenko.

Bamieh

The code looks good; Although i believe there are many any types that could be typed; these will be very useful for future refactors.

I'm also curious why you've decided for a separate plugin for the UI instead of baking it in alerting?

Not all the i18n ids are following the naming convension outlined in this guide: https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/GUIDELINE.md I've suggested edits on many of them

x-pack/legacy/plugins/alerting_ui/np_ready/public/application/app.tsx

Bamieh · 2019-10-21T15:24:14Z

x-pack/legacy/plugins/alerting_ui/np_ready/public/application/home.tsx

+        <EuiSpacer size="s" />
+
+        <Switch>
+          {canShowActions && <Route exact path={routeToActions} component={ActionsList} />}


I'm not sure about this but maybe canShowActions should be wrapping the <Switch>?

There will be more routes added later on and only the one above will be related to canShowActions

x-pack/legacy/plugins/alerting_ui/np_ready/public/application/lib/doc_title.ts

x-pack/legacy/plugins/actions/server/builtin_action_types/slack.ts

x-pack/legacy/plugins/actions/server/builtin_action_types/email.ts

x-pack/legacy/plugins/actions/server/builtin_action_types/server_log.ts

x-pack/legacy/plugins/actions/server/builtin_action_types/webhook.ts

...ugins/alerting_ui/np_ready/public/application/components/page_error/page_error_forbidden.tsx

...ugins/alerting_ui/np_ready/public/application/components/page_error/page_error_not_exist.tsx

mikecote · 2019-10-21T18:20:36Z

@Bamieh thanks for the review. The removal of the any in TypeScript will be done with this card: https://github.com/elastic/kibana/projects/26#card-28081120. I created the card to avoid adding more merge conflicts with @YulNaumenko's upcoming PR.

The UI is developed in a separate plugin due to it containing alerting and actions plugin UI. We want to still render the UI for actions when the alerting plugin is disabled. The naming of the plugin may have to change to be more clear but this is the intent.

Thanks for the link to naming conventions, will give it a read!

elasticmachine · 2019-10-21T19:37:13Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 85578a4

Bamieh

LGTM!

mikecote · 2019-10-22T17:28:21Z

PR is marked merged automatically due to us now only using feature/alerting_ui as the single feature branch. A single PR for review into master will now be required instead of a series of PRs.

mikecote and others added 10 commits October 9, 2019 13:43

WIP

4a3f2ac

Move files over to new plugin

9cd4e5a

Register plugin

73ece0a

Rename kibana.json and translation keys

3c3e6bc

Fix failing type check

579145a

Move alerting into kibana management section

5b7ef4b

Fix app references within /public

ac28c98

[Alerts] Create UI for alerting tabs navigation #47754

fb28e9a

Change actions list to pull from actions API

3b3aadf

Switch to EuiBasicTable

c3d16f2

mikecote added Feature:Alerting Team:Stack Services labels Oct 10, 2019

mikecote assigned mikecote and YulNaumenko Oct 10, 2019

YulNaumenko and others added 15 commits October 10, 2019 12:15

Moved management section registration to Plugin setup

bf8179e

Start work on sorting

05a63f3

Add sorting support

d5988ac

Add pagination

211b39d

More types

ecdc17a

Cleanup api.ts

6821358

Dislpay action type instead of actionTypeId

4eb77ab

More cleanup

e188769

Avoid loading action types on every load of actions, though this flic…

2c00fc9

…kers in the UI the action type column (from id to name)

Fixed infinite loop useEffect execution for loadActionTypes

e7af823

Implemented Add Action dropdown button with exposed types options ret…

fa1e776

…rieved from server action types list

Remove duplicated code

39ad16b

Add searching

979f06b

Remove content wrapper within wrapper

461bede

Use EuiSearchBar

72cc5f2

Sort action types alphabetically

f31d052

mikecote added the review label Oct 18, 2019

bmcconaghy reviewed Oct 18, 2019

View reviewed changes

This comment has been minimized.

Sign in to view

mikecote added 2 commits October 18, 2019 12:41

PR feedback pt1

70e8606

Remove content wrapper

aca85c5

This comment has been minimized.

Sign in to view

mikecote added 3 commits October 18, 2019 14:37

Switch to in memory table

afffcf3

Cleanup imports

ba533e9

Rename actions context filename

f8b31a2

YulNaumenko reviewed Oct 18, 2019

View reviewed changes

x-pack/legacy/plugins/alerting_ui/np_ready/public/plugin.ts Outdated Show resolved Hide resolved

Rename ActionsPlugin to Plugin to match filename

dfca1a1

YulNaumenko approved these changes Oct 18, 2019

View reviewed changes

This comment has been minimized.

Sign in to view

Merge branch 'feature/alerting_ui' of github.com:elastic/kibana into …

6f51717

…feature/alerting_ui_plugin

This comment has been minimized.

Sign in to view

pmuellr reviewed Oct 21, 2019

View reviewed changes

...ns/alerting_ui/np_ready/public/application/sections/actions_list/components/actions_list.tsx Outdated Show resolved Hide resolved

pmuellr reviewed Oct 21, 2019

View reviewed changes

PR feedback

7468750

Bamieh reviewed Oct 21, 2019

View reviewed changes

This comment has been minimized.

Sign in to view

Apply PR feedback

85578a4

mikecote requested a review from a team October 22, 2019 16:56

Bamieh approved these changes Oct 22, 2019

View reviewed changes

mikecote merged commit 85578a4 into feature/alerting_ui Oct 22, 2019

mikecote deleted the feature/alerting_ui_plugin branch October 23, 2019 19:57

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Initial alerting UI and actions list #47843

Initial alerting UI and actions list #47843

mikecote commented Oct 10, 2019 •

edited

Loading

elasticmachine commented Oct 10, 2019

bmcconaghy left a comment

bmcconaghy Oct 18, 2019

mikecote Oct 18, 2019

This comment has been minimized.

This comment has been minimized.

YulNaumenko left a comment

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

pmuellr left a comment

pmuellr Oct 21, 2019

mikecote Oct 21, 2019

Bamieh left a comment •

edited

Loading

Bamieh Oct 21, 2019

mikecote Oct 21, 2019

This comment has been minimized.

mikecote commented Oct 21, 2019

elasticmachine commented Oct 21, 2019

Bamieh left a comment

mikecote commented Oct 22, 2019

Initial alerting UI and actions list #47843

Initial alerting UI and actions list #47843

Conversation

mikecote commented Oct 10, 2019 • edited Loading

elasticmachine commented Oct 10, 2019

bmcconaghy left a comment

Choose a reason for hiding this comment

bmcconaghy Oct 18, 2019

Choose a reason for hiding this comment

mikecote Oct 18, 2019

Choose a reason for hiding this comment

This comment has been minimized.

This comment has been minimized.

YulNaumenko left a comment

Choose a reason for hiding this comment

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

pmuellr left a comment

Choose a reason for hiding this comment

pmuellr Oct 21, 2019

Choose a reason for hiding this comment

mikecote Oct 21, 2019

Choose a reason for hiding this comment

Bamieh left a comment • edited Loading

Choose a reason for hiding this comment

Bamieh Oct 21, 2019

Choose a reason for hiding this comment

mikecote Oct 21, 2019

Choose a reason for hiding this comment

This comment has been minimized.

mikecote commented Oct 21, 2019

elasticmachine commented Oct 21, 2019

💚 Build Succeeded

Bamieh left a comment

Choose a reason for hiding this comment

mikecote commented Oct 22, 2019

mikecote commented Oct 10, 2019 •

edited

Loading

Bamieh left a comment •

edited

Loading