-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/app switcher #4994
Merged
Merged
Fix/app switcher #4994
Changes from 2 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
dfe8dcc
[chrome] indicate which app is active in the switcher
4d20063
[chrome/appSwitcher] when navigating to an app, ensure the page reloads
16165d6
[appSwitcher] move app switcher template into directive
344aed4
[appSwitcher] check for chrome on $scope
10f5f1a
[appSwitcher] read/write to $window for test mocking
79968f9
[jquery] add findTestSubject helper to jquery
e49e045
Merge branch 'implement/testSubjectHelper' into fix/appSwitcher
4464cfd
[appSwitcher] added tests
d47e84c
[appSwitcher] added tests
a1c7e7f
[appSwitcher] use a mockable window.location service
a3fdda4
[appSwitcher/tests] mock domLocation rather than trying to mod globals
72a6100
[appSwitcher] compare to the href of the clicked element, not necessa…
9214b25
[appSwitcher] use event.stopPropagation()
e714193
[appSwitcher] only refresh when the new url uses a hash
96a3406
[appSwitcher/tests] update to match propagation based fixes
c46cb43
[findTestSubject] remove
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,33 @@ | ||
var parse = require('url').parse; | ||
|
||
require('../appSwitcher/appSwitcher.less'); | ||
|
||
require('ui/modules') | ||
.get('kibana') | ||
.directive('appSwitcher', function () { | ||
return { | ||
restrict: 'A', | ||
controllerAs: 'switcher', | ||
controller: function () { | ||
|
||
// links don't cause full-navigation events in certain scenarios | ||
// so we force them when needed | ||
this.ensureNavigation = function (event, app) { | ||
if (event.isDefaultPrevented() || event.altKey || event.metaKey || event.ctrlKey) { | ||
return; | ||
} | ||
|
||
var toParsed = parse(app.url); | ||
var fromParsed = parse(window.location.href); | ||
var sameProto = toParsed.protocol === fromParsed.protocol; | ||
var sameHost = toParsed.host === fromParsed.host; | ||
var samePath = toParsed.path === fromParsed.path; | ||
|
||
if (sameProto && sameHost && samePath) { | ||
window.location.reload(true); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Do you want to stop propagation here? I'm being sent to the href after reloading. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Good call |
||
} | ||
}; | ||
|
||
} | ||
}; | ||
}); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could use a test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will do