Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Fix spaces api example json #50411

Merged
merged 2 commits into from
Feb 7, 2020
Merged

[docs] Fix spaces api example json #50411

merged 2 commits into from
Feb 7, 2020

Conversation

Conky5
Copy link
Contributor

@Conky5 Conky5 commented Nov 12, 2019

Summary

Make this example properly formatted json.

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

- [ ] This was checked for cross-browser compatibility, including a check against IE11
- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
- [ ] Documentation was added for features that require explanation or tutorials
- [ ] Unit or functional tests were updated or added to match the most common scenarios
- [ ] This was checked for keyboard-only and screenreader accessibility

For maintainers

@Conky5
[docs] Fix spaces api example json
834dc19 
Make this example properly formatted json.
@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-docs (Team:Docs)

@streamich
Copy link
Contributor

@elasticmachine merge upstream

@streamich streamich requested a review from a team February 7, 2020 11:01
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@gchaps gchaps added the release_note:skip Skip the PR/issue when compiling release notes label Feb 7, 2020
gchaps
gchaps approved these changes Feb 7, 2020
View reviewed changes
Copy link
Contributor

@gchaps gchaps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gchaps gchaps added the v8.0.0 label Feb 7, 2020
@gchaps gchaps merged commit 12fcf01 into elastic:master Feb 7, 2020
@Conky5 Conky5 deleted the fix-spaces-api-json branch February 7, 2020 15:19
@gchaps gchaps mentioned this pull request Feb 7, 2020
Merged
gchaps pushed a commit to gchaps/kibana that referenced this pull request Feb 7, 2020
@Conky5 @elasticmachine @gchaps
[docs] Fix spaces api example json (elastic#50411)
84feaf9 
Make this example properly formatted json.

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@gchaps gchaps mentioned this pull request Feb 7, 2020
Merged
gchaps pushed a commit to gchaps/kibana that referenced this pull request Feb 7, 2020
@Conky5 @elasticmachine @gchaps
[docs] Fix spaces api example json (elastic#50411)
de21ccd 
Make this example properly formatted json.

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@gchaps gchaps mentioned this pull request Feb 7, 2020
Merged
gchaps pushed a commit to gchaps/kibana that referenced this pull request Feb 7, 2020
@Conky5 @elasticmachine @gchaps
[docs] Fix spaces api example json (elastic#50411)
a12d654 
Make this example properly formatted json.

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
gchaps added a commit that referenced this pull request Feb 7, 2020
@gchaps @Conky5 @elasticmachine
[docs] Fix spaces api example json (#50411) (#57121)
c82cf60 
Make this example properly formatted json.

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Chris Koehnke <chris.koehnke@pm.me>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
gchaps added a commit that referenced this pull request Feb 7, 2020
@gchaps @Conky5 @elasticmachine
[docs] Fix spaces api example json (#50411) (#57120)
a529fc9 
Make this example properly formatted json.

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Chris Koehnke <chris.koehnke@pm.me>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
gchaps added a commit that referenced this pull request Feb 7, 2020
@gchaps @Conky5 @elasticmachine
[docs] Fix spaces api example json (#50411) (#57118)
7a38857 
Make this example properly formatted json.

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Chris Koehnke <chris.koehnke@pm.me>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
gmmorris added a commit to gmmorris/kibana that referenced this pull request Feb 9, 2020
@gmmorris
Merge remote-tracking branch 'upstream/master' into alerting/get-aler…
03c405f 
…t-state

* upstream/master: (96 commits)
  top nav ts arg support (elastic#56984)
  [SIEM][detection engine] Limit network rules to filebeat source semantics (elastic#57130)
  Add docs for alerting and action settings (elastic#57035)
  Add Test to Verify Endpoint App Landing Page (elastic#57129)
  Update `markdown-to-jsx` (`6.9.3` → `6.11.0`) and `url-parse` (`1.4.4` → `1.4.7`) dependencies. (elastic#57126)
  chore(NA): removes use of parallel option in the terser minimizer (elastic#57077)
  [ML] New Platform server shim: update file data visualizer routes to use new platform router (elastic#56972)
  Specifying valid licenses for the Graph feature (elastic#55911)
  [APM][docs] Add troubleshooting for non-indexed fields (elastic#54948)
  [ML] DF Analytics creation: update schema definition for create route (elastic#56979)
  Remove Kibana a11y guide in favor of EUI (elastic#57021)
  [Logs UI] Set streamLive false in URL state when arriving from link-to (elastic#56329)
  [docs] Fix spaces api example json (elastic#50411)
  Add new config for filebeat index name (elastic#56920)
  [Metrics-UI] Fix toolbar popover for metrics table row (elastic#56796)
  Saved Objects testing (elastic#56965)
  Disabled categorization stats validation (elastic#57087)
  [Rollups] Server NP migration (elastic#55606)
  [Metrics UI] Limit group by selector to only 2 fields (elastic#56800)
  fix auto closing new vis modal when navigating to lens or when navigating away with browser history (elastic#56998)
  ...
gmmorris added a commit to gmmorris/kibana that referenced this pull request Feb 9, 2020
@gmmorris
Merge branch 'master' into alerting/alert-instances
187589f 
* master: (96 commits)
  top nav ts arg support (elastic#56984)
  [SIEM][detection engine] Limit network rules to filebeat source semantics (elastic#57130)
  Add docs for alerting and action settings (elastic#57035)
  Add Test to Verify Endpoint App Landing Page (elastic#57129)
  Update `markdown-to-jsx` (`6.9.3` → `6.11.0`) and `url-parse` (`1.4.4` → `1.4.7`) dependencies. (elastic#57126)
  chore(NA): removes use of parallel option in the terser minimizer (elastic#57077)
  [ML] New Platform server shim: update file data visualizer routes to use new platform router (elastic#56972)
  Specifying valid licenses for the Graph feature (elastic#55911)
  [APM][docs] Add troubleshooting for non-indexed fields (elastic#54948)
  [ML] DF Analytics creation: update schema definition for create route (elastic#56979)
  Remove Kibana a11y guide in favor of EUI (elastic#57021)
  [Logs UI] Set streamLive false in URL state when arriving from link-to (elastic#56329)
  [docs] Fix spaces api example json (elastic#50411)
  Add new config for filebeat index name (elastic#56920)
  [Metrics-UI] Fix toolbar popover for metrics table row (elastic#56796)
  Saved Objects testing (elastic#56965)
  Disabled categorization stats validation (elastic#57087)
  [Rollups] Server NP migration (elastic#55606)
  [Metrics UI] Limit group by selector to only 2 fields (elastic#56800)
  fix auto closing new vis modal when navigating to lens or when navigating away with browser history (elastic#56998)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gchaps gchaps gchaps approved these changes

Assignees
No one assigned
Labels
release_note:skip Skip the PR/issue when compiling release notes review Team:Docs v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Conky5 @elasticmachine @streamich @gchaps