Retry authentication and other connection failures in Saved Object migrations #51324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rudolf
added
Team:Core
|
Pinging @elastic/kibana-platform (Team:Platform) |
joshdover
reviewed
Nov 21, 2019
joshdover
reviewed
Nov 21, 2019
|
I changed the kibana user's password while starting up from x-pack directory and got tons of errors repeating. Then I checked the kibana user's password back to what kibana was configured to use (around timestamp [14:00:05.764]) and it instantly started working. This wasn't an exhaustive test, but a good sign. |
💚 Build Succeeded |
|
This is interesting to me, I changed the password in elasticsearch to be wrong again and opened Kibana in my browser. |
|
This is fun... while you're logged in to Kibana and testing things run this script to constantly change the kibana user's password and make sure the Kibana process never crashes; while (true); do curl -k -XPUT --basic "http://elastic:changeme@localhost:9220/_xpack/security/user/kibana/_password?pretty" -H 'Content-Type: application/json' -d'{ "password": "changeit" }'; echo "bad password"; sleep 4; curl -k -XPUT --basic "http://elastic:changeme@localhost:9220/_xpack/security/user/kibana/_password?pretty" -H 'Content-Type: application/json' -d'{ "password": "changeme" }'; echo "good password"; sleep 8; done |
rudolf
added
the
release_note:skip
joshdover
reviewed
Nov 21, 2019
|
|
||
| // TODO: Replace with APICaller from './scoped_cluster_client' once #46668 is merged | ||
| export function migrationsRetryCallCluster( | ||
| apiCaller: ( |
There was a problem hiding this comment.
optional: use APICaller since it exists now
| log: Logger, | ||
| delay: number = 2500 | ||
| ) { | ||
| const previousErrors: string[] = []; |
There was a problem hiding this comment.
optional: use Set instead of array
💔 Build Failed |
💔 Build Failed |
💚 Build Succeeded |
rudolf
added a commit
to rudolf/kibana
that referenced
this pull request
Nov 22, 2019
…grations (elastic#51324) * Retry authentication and other connection failures in migrations * Log migration ES connection errors once, retry every 2.5s * Test migrations es connection error logging * retry on AuthorizationExceptions during migration * Set delay to 1 for tests
rudolf
added a commit
to rudolf/kibana
that referenced
this pull request
Nov 22, 2019
…grations (elastic#51324) * Retry authentication and other connection failures in migrations * Log migration ES connection errors once, retry every 2.5s * Test migrations es connection error logging * retry on AuthorizationExceptions during migration * Set delay to 1 for tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #51242 by retrying authentication and other failures encountered from
callClusterin the Saved Object migrator.Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.For maintainers