Global timezones #5134
Merged
Global timezones #5134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -20,6 +23,12 @@ define(function () { | |||
| value: 'MMMM Do YYYY, HH:mm:ss.SSS', | |||
| description: 'When displaying a pretty formatted date, use this format', | |||
| }, | |||
| 'dateFormat:tz': { | |||
| value: 'Default', | |||
There was a problem hiding this comment.
Maybe this should be Auto detect or something similar?
There was a problem hiding this comment.
I'd use either "browser" or "local" to try to make it clear how the detection is being done. Old versions of kibana used "browser"
|
Few small comments, otherwise looks good. |
|
Spent some quality time with this one. Changing the time zone does in fact change the |
|
way to go! |
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables changing the application-wide timezone. Closes #1600