-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[skip-ci] Expression Lifecycle Docs #51494
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timductive
added
Team:Docs
Team:Presentation
Presentation Team for Dashboard, Input Controls, and Canvas
labels
Nov 22, 2019
Pinging @elastic/kibana-docs (Team:Docs) |
Pinging @elastic/kibana-canvas (Team:Canvas) |
timductive
added
release_note:skip
Skip the PR/issue when compiling release notes
v7.6.0
review
labels
Nov 22, 2019
2 tasks
KOTungseth
reviewed
Dec 11, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work on the expression docs! These examples are super helpful.
I'm pausing my review here, and will pick this back up tomorrow. Please let me know if you have any questions in the meantime.
KOTungseth
reviewed
Dec 12, 2019
KOTungseth
reviewed
Dec 16, 2019
timductive
force-pushed
the
expression-docs
branch
from
December 16, 2019 21:08
923430f
to
0c4ac15
Compare
Co-Authored-By: Catherine Liu <catherineqliu@outlook.com>
Co-Authored-By: Catherine Liu <catherineqliu@outlook.com>
timductive
force-pushed
the
expression-docs
branch
from
January 2, 2020 19:05
5bff9b6
to
c9b8dad
Compare
Co-Authored-By: Vadim Dalecky <streamich@users.noreply.github.com>
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Jan 3, 2020
* master: Rename `/api/security/oidc` to `/api/security/oidc/callback`. (elastic#53886) Updating transitive dependencies to use handlebars@4.5.3 (elastic#53899) [Reporting/Tests] consolidate functional test configs (elastic#52671) [Reporting] Correct the docvalue_fields params in the search query Download CSV from Dashboard Panel (elastic#52833) [Test/Newsfeed] Re-enable test and add news item to be filtered (elastic#53905) cleanup server-log action (elastic#53326) [Uptime] Delete uptime eslint rule skip (elastic#50912) [skip-ci] Expression Lifecycle Docs (elastic#51494) [Endpoint] add react router to endpoint app (elastic#53808) [SIEM][Detection Engine] Silence 409 errors on signal creation (elastic#53859) [Maps] get max_result_window and max_inner_result_window from index settings (elastic#53500) [ML] New Platform server shim: update analytics routes to use new platform router (elastic#53521) fixes typo on engine detection page (elastic#53877)
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Jan 3, 2020
* master: Rename `/api/security/oidc` to `/api/security/oidc/callback`. (elastic#53886) Updating transitive dependencies to use handlebars@4.5.3 (elastic#53899) [Reporting/Tests] consolidate functional test configs (elastic#52671) [Reporting] Correct the docvalue_fields params in the search query Download CSV from Dashboard Panel (elastic#52833) [Test/Newsfeed] Re-enable test and add news item to be filtered (elastic#53905) cleanup server-log action (elastic#53326) [Uptime] Delete uptime eslint rule skip (elastic#50912) [skip-ci] Expression Lifecycle Docs (elastic#51494) [Endpoint] add react router to endpoint app (elastic#53808) [SIEM][Detection Engine] Silence 409 errors on signal creation (elastic#53859) [Maps] get max_result_window and max_inner_result_window from index settings (elastic#53500) [ML] New Platform server shim: update analytics routes to use new platform router (elastic#53521) fixes typo on engine detection page (elastic#53877) [Maps] push mapbox value extraction from VectorStyle and into DynamicStyleProperty (elastic#53806) Fix suggested value for time_zone in range query (elastic#53841) Clean up generic hooks, use react-use instead (elastic#53822)
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Jan 3, 2020
…ris/kibana into alerting/created_at-and-updated_at * 'alerting/created_at-and-updated_at' of github.com:gmmorris/kibana: Rename `/api/security/oidc` to `/api/security/oidc/callback`. (elastic#53886) Updating transitive dependencies to use handlebars@4.5.3 (elastic#53899) [Reporting/Tests] consolidate functional test configs (elastic#52671) [Reporting] Correct the docvalue_fields params in the search query Download CSV from Dashboard Panel (elastic#52833) [Test/Newsfeed] Re-enable test and add news item to be filtered (elastic#53905) cleanup server-log action (elastic#53326) [Uptime] Delete uptime eslint rule skip (elastic#50912) [skip-ci] Expression Lifecycle Docs (elastic#51494) [Endpoint] add react router to endpoint app (elastic#53808) [SIEM][Detection Engine] Silence 409 errors on signal creation (elastic#53859) [Maps] get max_result_window and max_inner_result_window from index settings (elastic#53500) [ML] New Platform server shim: update analytics routes to use new platform router (elastic#53521) fixes typo on engine detection page (elastic#53877) [Maps] push mapbox value extraction from VectorStyle and into DynamicStyleProperty (elastic#53806) Fix suggested value for time_zone in range query (elastic#53841) Clean up generic hooks, use react-use instead (elastic#53822)
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Jan 3, 2020
…t-types * alerting/created_at-and-updated_at: updatedAt should equal createdAt on creation Move index patterns: src/legacy/core_plugins/data 👉 src/plugins/data (elastic#53794) moved Task Manager server code under "server" directory (elastic#53777) Rename `/api/security/oidc` to `/api/security/oidc/callback`. (elastic#53886) Updating transitive dependencies to use handlebars@4.5.3 (elastic#53899) [Reporting/Tests] consolidate functional test configs (elastic#52671) [Reporting] Correct the docvalue_fields params in the search query Download CSV from Dashboard Panel (elastic#52833) [Test/Newsfeed] Re-enable test and add news item to be filtered (elastic#53905) cleanup server-log action (elastic#53326) [Uptime] Delete uptime eslint rule skip (elastic#50912) [skip-ci] Expression Lifecycle Docs (elastic#51494) [Endpoint] add react router to endpoint app (elastic#53808) [SIEM][Detection Engine] Silence 409 errors on signal creation (elastic#53859) [Maps] get max_result_window and max_inner_result_window from index settings (elastic#53500) [ML] New Platform server shim: update analytics routes to use new platform router (elastic#53521) fixes typo on engine detection page (elastic#53877) [Maps] push mapbox value extraction from VectorStyle and into DynamicStyleProperty (elastic#53806) Fix suggested value for time_zone in range query (elastic#53841) Clean up generic hooks, use react-use instead (elastic#53822)
timductive
added a commit
to timductive/kibana
that referenced
this pull request
Jan 3, 2020
* adding context and arguments section * Change Your Expression docs section for Canvas Expression docs * typo or somethin * Adding Expressions Only Fetch and Manipulate Data section * Added argument sections of expression docs * Add Composing Functions and Sub Expression docs * adding shaun changes * removing redundant lifecycle link * PR edits * fixing links * more edits * more edits from kaarina * Update docs/canvas/canvas-expression-lifecycle.asciidoc Co-Authored-By: Catherine Liu <catherineqliu@outlook.com> * Update docs/canvas/canvas-expression-lifecycle.asciidoc Co-Authored-By: Catherine Liu <catherineqliu@outlook.com> * Update docs/canvas/canvas-expression-lifecycle.asciidoc Co-Authored-By: Vadim Dalecky <streamich@users.noreply.github.com> * more edits for images * adding image showing no legend * escaping underscore * fixing underscore again * fixing image name * adjusting image height Co-authored-by: Poff Poffenberger <poffdeluxe@gmail.com> Co-authored-by: Catherine Liu <catherineqliu@outlook.com> Co-authored-by: Corey Robertson <crob611@gmail.com> Co-authored-by: Vadim Dalecky <streamich@users.noreply.github.com>
timductive
added a commit
to timductive/kibana
that referenced
this pull request
Jan 3, 2020
* adding context and arguments section * Change Your Expression docs section for Canvas Expression docs * typo or somethin * Adding Expressions Only Fetch and Manipulate Data section * Added argument sections of expression docs * Add Composing Functions and Sub Expression docs * adding shaun changes * removing redundant lifecycle link * PR edits * fixing links * more edits * more edits from kaarina * Update docs/canvas/canvas-expression-lifecycle.asciidoc Co-Authored-By: Catherine Liu <catherineqliu@outlook.com> * Update docs/canvas/canvas-expression-lifecycle.asciidoc Co-Authored-By: Catherine Liu <catherineqliu@outlook.com> * Update docs/canvas/canvas-expression-lifecycle.asciidoc Co-Authored-By: Vadim Dalecky <streamich@users.noreply.github.com> * more edits for images * adding image showing no legend * escaping underscore * fixing underscore again * fixing image name * adjusting image height Co-authored-by: Poff Poffenberger <poffdeluxe@gmail.com> Co-authored-by: Catherine Liu <catherineqliu@outlook.com> Co-authored-by: Corey Robertson <crob611@gmail.com> Co-authored-by: Vadim Dalecky <streamich@users.noreply.github.com>
timductive
added a commit
that referenced
this pull request
Jan 3, 2020
* adding context and arguments section * Change Your Expression docs section for Canvas Expression docs * typo or somethin * Adding Expressions Only Fetch and Manipulate Data section * Added argument sections of expression docs * Add Composing Functions and Sub Expression docs * adding shaun changes * removing redundant lifecycle link * PR edits * fixing links * more edits * more edits from kaarina * Update docs/canvas/canvas-expression-lifecycle.asciidoc Co-Authored-By: Catherine Liu <catherineqliu@outlook.com> * Update docs/canvas/canvas-expression-lifecycle.asciidoc Co-Authored-By: Catherine Liu <catherineqliu@outlook.com> * Update docs/canvas/canvas-expression-lifecycle.asciidoc Co-Authored-By: Vadim Dalecky <streamich@users.noreply.github.com> * more edits for images * adding image showing no legend * escaping underscore * fixing underscore again * fixing image name * adjusting image height Co-authored-by: Poff Poffenberger <poffdeluxe@gmail.com> Co-authored-by: Catherine Liu <catherineqliu@outlook.com> Co-authored-by: Corey Robertson <crob611@gmail.com> Co-authored-by: Vadim Dalecky <streamich@users.noreply.github.com> Co-authored-by: Poff Poffenberger <poffdeluxe@gmail.com> Co-authored-by: Catherine Liu <catherineqliu@outlook.com> Co-authored-by: Corey Robertson <crob611@gmail.com> Co-authored-by: Vadim Dalecky <streamich@users.noreply.github.com>
timductive
added a commit
that referenced
this pull request
Jan 3, 2020
* adding context and arguments section * Change Your Expression docs section for Canvas Expression docs * typo or somethin * Adding Expressions Only Fetch and Manipulate Data section * Added argument sections of expression docs * Add Composing Functions and Sub Expression docs * adding shaun changes * removing redundant lifecycle link * PR edits * fixing links * more edits * more edits from kaarina * Update docs/canvas/canvas-expression-lifecycle.asciidoc Co-Authored-By: Catherine Liu <catherineqliu@outlook.com> * Update docs/canvas/canvas-expression-lifecycle.asciidoc Co-Authored-By: Catherine Liu <catherineqliu@outlook.com> * Update docs/canvas/canvas-expression-lifecycle.asciidoc Co-Authored-By: Vadim Dalecky <streamich@users.noreply.github.com> * more edits for images * adding image showing no legend * escaping underscore * fixing underscore again * fixing image name * adjusting image height Co-authored-by: Poff Poffenberger <poffdeluxe@gmail.com> Co-authored-by: Catherine Liu <catherineqliu@outlook.com> Co-authored-by: Corey Robertson <crob611@gmail.com> Co-authored-by: Vadim Dalecky <streamich@users.noreply.github.com> Co-authored-by: Poff Poffenberger <poffdeluxe@gmail.com> Co-authored-by: Catherine Liu <catherineqliu@outlook.com> Co-authored-by: Corey Robertson <crob611@gmail.com> Co-authored-by: Vadim Dalecky <streamich@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
release_note:skip
Skip the PR/issue when compiling release notes
review
Team:Docs
Team:Presentation
Presentation Team for Dashboard, Input Controls, and Canvas
v7.6.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #23032.
Adds context and arguments section for Expression lifecycle docs.
[skip ci]
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.- [ ] This was checked for cross-browser compatibility, including a check against IE11- [ ] Unit or functional tests were updated or added to match the most common scenarios- [ ] This was checked for keyboard-only and screenreader accessibilityFor maintainers
- [ ] This was checked for breaking API changes and was labeled appropriately- [ ] This includes a feature addition or change that requires a release note and was labeled appropriately