Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Console] Fix Safari height issue #51707

Merged
merged 1 commit into from
Nov 26, 2019

Conversation

jloleysens
Copy link
Contributor

@jloleysens jloleysens commented Nov 26, 2019

Summary

Addresses: #51702

Tested on Safari, FF, Chrome and Edge. Couldn't get Kibana to start on IE11 on current commit.

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

@jloleysens jloleysens added Feature:Console Dev Tools Console Feature v8.0.0 Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more release_note:skip Skip the PR/issue when compiling release notes v7.6.0 labels Nov 26, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/es-ui (Team:Elasticsearch UI)

Copy link
Contributor

@alisonelizabeth alisonelizabeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix LGTM. Tested on Chrome, FF, and Safari.

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@jloleysens jloleysens merged commit 5899aa5 into elastic:master Nov 26, 2019
@jloleysens jloleysens deleted the console/safari-fix branch November 26, 2019 13:23
jloleysens added a commit to jloleysens/kibana that referenced this pull request Nov 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Console Dev Tools Console Feature release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v7.6.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants