Converting indexPattern to indexList is now async #5173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since there will soon be a pre-flight request to elasticsearch on certain index patterns when trying to determine which indices match, the conversion must now happen asynchronously. The function now returns a promise that is fulfilled with the matching array of index names.
| @@ -100,7 +107,7 @@ define(function (require) { | |||
| }; | |||
|
|
|||
| SegmentedReq.prototype.isIncomplete = function () { | |||
| return this._queue.length > 0; | |||
| return !this._queueCreated || this._queue.length > 0; | |||
There was a problem hiding this comment.
might read better as this._queueCreated &&. I missed the ! at first and thought this was backwards
There was a problem hiding this comment.
That wouldn't be the same conditional logic though: this is only negating the first half of the condition.
|
Seems to work great, just waiting for responses to my comments. Otherwise LGTM |
These changes are internally cosmetic for the sake of adding clarity for developers and ensuring that state is changed in the most appropriate places to help prevent future regressions.
|
I pushed two changes here:
|
|
LGTM |
spalger
added a commit
that referenced
this pull request
Oct 22, 2015
Converting indexPattern to indexList is now async
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since there will soon be a pre-flight request to elasticsearch on
certain index patterns when trying to determine which indices match, the
conversion must now happen asynchronously. The function now returns a
promise that is fulfilled with the matching array of index names.
This is necessary for #4342, but it does not complete that ticket.