Ability to disable highlighting #5197
Conversation
|
Jenkins standing by to test this. If you aren't a maintainer, you can ignore this comment. Someone with commit access, please review this and clear it for Jenkins to run; then say 'jenkins, test it'. |
Filirom1
changed the title
| @@ -136,6 +136,7 @@ define(function (require) { | |||
| index: $scope.indexPattern.id, | |||
| timefield: $scope.indexPattern.timeFieldName, | |||
| savedSearch: savedSearch, | |||
| highlight: config.get('discover:highlight'), | |||
There was a problem hiding this comment.
Attaching this to $scope.opts is not necessary, this value isn't used outside of the immediate context.
|
I like the functionality. Please see comments. |
|
Ok thanks, I am working on it |
|
Does this affect highlighting on the dashboard? |
|
No, this PR only affects the discover page. |
|
I'm talking specifically about search sources rendered on the dashboard. I believe that the highlighting settings applied in discover is what causes highlighting to work when a searchSource is rendered as a panel. |
|
This would affect both discover and the dashboard. The parameter should probably be namespaced to the doc table |
|
It affects both discover and the dashboard (saved searches) |
| @@ -59,6 +59,10 @@ define(function (require) { | |||
| value: 500, | |||
| description: 'The number of rows to show in the table', | |||
| }, | |||
| 'discover:highlight': { | |||
There was a problem hiding this comment.
Given that this affects both discover and dashboard, this should be doc_table:highlight
|
Done |
|
LGTM, going into 4.3.0 |
Ability to disable highlighting
|
Thanks |
Hi,
When storing very big documents in ElasticSearch, highliting make requests very slow.
In my case, the same request with highlighting takes 76s and without highlighting 3s.
This is the reason why I would like to disable highlighting in some cases.
Cheers