-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Monitoring] Migrate license expiration alert to Kibana alerting #54260
Closed
chrisronline
wants to merge
73
commits into
elastic:master
from
chrisronline:monitoring/kibana_alerts
Closed
[Monitoring] Migrate license expiration alert to Kibana alerting #54260
chrisronline
wants to merge
73
commits into
elastic:master
from
chrisronline:monitoring/kibana_alerts
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…after creating alerts
… storing the email to receive alerts
…y in an error state
💔 Build FailedHistory
To update your PR or re-run it, just comment with: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #42960
Replaces #49219
This is the first PR of a set of PRs aimed to migrate the six watcher-based cluster alerts to use the Kibana alerting framework.
This PR focuses on the license expiration alert, as well as laying out the foundation of how the rest of the alerts will be migrated.
There are three main things we need to do to accomplish this:
For the first one, the ES team will be introducing an api that will allow us to do that from the UI (pending ticket creation). For testing this PR, let's assume those are disabled properly and we don't need to worry about that now.
For the second one, we want to slowly merge all of this work into master (to avoid one large PR) so we are going to add a constant that will be set to
false
until all of the alerts are ready. Then, the final PR will remove this constant and all of the new alerts will be available to users.Finally, for the last one, we want to ensure the messaging is consistent (even though it might be somewhat poor) for this phase.
Screenshots
Testing
true
We need to easily simulate the scenario in which this alert would fire. To do that, we'll leverage the monitoring ingest pipeline to set an expiration date in the near future. See these commands:
TODO
.monitoring-alerts-*
should be removeddefault_admin_email
logic since we aren't using that in the Kibana alerting world